-
Notifications
You must be signed in to change notification settings - Fork 365
Added automated tests with cypress for Tenants form #9532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automated tests with cypress for Tenants form #9532
Conversation
fe71238
to
3cdea0a
Compare
Sporadic server-related failures were noticed here as well: A couple of API requests are made right after logging in, prior to dashboard rendering: So I just tried adding a fixed wait using |
Need a second opinion here -This test currently bundles add project and manage quotas with both parent and child tenants, which makes it quite large. Would it be better to break out add project and manage quotas into standalone tests? |
TODOs:
|
RE: the sporadic test failure... see #9515 (comment) (if we can bypass saving session in the API and some of the /dashboard GETs, most of the contention causing stale session writes should be removed. 🤞 |
3cdea0a
to
f3ec47a
Compare
Related issue on tenant deletion: #9512 |
339c7eb
to
42fcdcf
Compare
be75b2c
to
5d4ec73
Compare
f59a514
to
1fe2474
Compare
dd4684f
to
6f9f4bb
Compare
4e9c401
to
9fc6bb4
Compare
9fc6bb4
to
ee86e3e
Compare
@asirvadAbrahamVarghese I think this is good. Is there anything else to do here? If not, comment here and remove the WIP in the title. |
All good here, dropped WIP ✅ |
ee86e3e
to
17e3c76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CP4AIOPS-16943
Pr that adds cypress tests for Tenants form(Settings -> Application Settings ->Access Control -> Tenants)
@miq-bot assign @elsamaryv
@miq-bot add-label cypress
@miq-bot add-label test