Skip to content

Conversation

asirvadAbrahamVarghese
Copy link
Contributor

@asirvadAbrahamVarghese asirvadAbrahamVarghese commented Jul 29, 2025

CP4AIOPS-16943
Pr that adds cypress tests for Tenants form(Settings -> Application Settings ->Access Control -> Tenants)

  • Edit parent tenant
  • Add project to parent tenant
  • Manage quotas with parent tenant
  • Add, edit and delete child tenant
  • Add project to child tenant
  • Manage quotas with child tenant

@miq-bot assign @elsamaryv
@miq-bot add-label cypress
@miq-bot add-label test

@asirvadAbrahamVarghese asirvadAbrahamVarghese requested a review from a team as a code owner July 29, 2025 13:11
@asirvadAbrahamVarghese asirvadAbrahamVarghese force-pushed the tenants-form-automation-testing branch from fe71238 to 3cdea0a Compare July 29, 2025 14:07
@asirvadAbrahamVarghese
Copy link
Contributor Author

Sporadic server-related failures were noticed here as well:
image

A couple of API requests are made right after logging in, prior to dashboard rendering:
image

So I just tried adding a fixed wait using cy.wait immediately after login, before moving to the menu, which seems to help stabilize the test with fewer sporadic failures
CI Runs with wait:
attempt-1
image
attempt-2
image

CI run without wait
image

@asirvadAbrahamVarghese
Copy link
Contributor Author

Need a second opinion here -

This test currently bundles add project and manage quotas with both parent and child tenants, which makes it quite large. Would it be better to break out add project and manage quotas into standalone tests?

@asirvadAbrahamVarghese
Copy link
Contributor Author

asirvadAbrahamVarghese commented Jul 29, 2025

TODOs:

@jrafanie
Copy link
Member

RE: the sporadic test failure... see #9515 (comment) (if we can bypass saving session in the API and some of the /dashboard GETs, most of the contention causing stale session writes should be removed. 🤞

@asirvadAbrahamVarghese asirvadAbrahamVarghese changed the title Added automated tests with cypress for Tenants form [WIP] - Added automated tests with cypress for Tenants form Aug 6, 2025
@asirvadAbrahamVarghese asirvadAbrahamVarghese force-pushed the tenants-form-automation-testing branch from 3cdea0a to f3ec47a Compare August 6, 2025 19:21
@asirvadAbrahamVarghese
Copy link
Contributor Author

Related issue on tenant deletion: #9512

@asirvadAbrahamVarghese asirvadAbrahamVarghese force-pushed the tenants-form-automation-testing branch 2 times, most recently from 339c7eb to 42fcdcf Compare August 7, 2025 09:34
@asirvadAbrahamVarghese asirvadAbrahamVarghese force-pushed the tenants-form-automation-testing branch 2 times, most recently from be75b2c to 5d4ec73 Compare August 14, 2025 03:29
@asirvadAbrahamVarghese asirvadAbrahamVarghese force-pushed the tenants-form-automation-testing branch 4 times, most recently from f59a514 to 1fe2474 Compare August 14, 2025 07:14
@asirvadAbrahamVarghese asirvadAbrahamVarghese force-pushed the tenants-form-automation-testing branch 3 times, most recently from dd4684f to 6f9f4bb Compare August 19, 2025 08:50
@asirvadAbrahamVarghese asirvadAbrahamVarghese force-pushed the tenants-form-automation-testing branch 3 times, most recently from 4e9c401 to 9fc6bb4 Compare September 1, 2025 06:41
@asirvadAbrahamVarghese asirvadAbrahamVarghese force-pushed the tenants-form-automation-testing branch from 9fc6bb4 to ee86e3e Compare September 24, 2025 10:32
@jrafanie
Copy link
Member

@asirvadAbrahamVarghese I think this is good. Is there anything else to do here? If not, comment here and remove the WIP in the title.

@asirvadAbrahamVarghese asirvadAbrahamVarghese changed the title [WIP] - Added automated tests with cypress for Tenants form Added automated tests with cypress for Tenants form Sep 26, 2025
@asirvadAbrahamVarghese
Copy link
Contributor Author

All good here, dropped WIP ✅

@asirvadAbrahamVarghese asirvadAbrahamVarghese force-pushed the tenants-form-automation-testing branch from ee86e3e to 17e3c76 Compare September 26, 2025 10:16
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie merged commit a2407fd into ManageIQ:master Sep 26, 2025
18 checks passed
@jrafanie jrafanie assigned jrafanie and unassigned GilbertCherrie and elsamaryv Sep 26, 2025
@asirvadAbrahamVarghese asirvadAbrahamVarghese deleted the tenants-form-automation-testing branch October 3, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants