Schedule form cypress refactor #9549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
reviewed
Aug 8, 2025
jrafanie
reviewed
Aug 8, 2025
|
we're red based on the prior change on master... as soon as that's fixed, this should be ready for re-review. |
jrafanie
reviewed
Aug 8, 2025
asirvadAbrahamVarghese
force-pushed
the
schedule-form-cypress-refactor
branch
4 times, most recently
from
8cef813 to
049d7f1
Compare
asirvadAbrahamVarghese
force-pushed
the
schedule-form-cypress-refactor
branch
from
049d7f1 to
35e263c
Compare
jrafanie
reviewed
Aug 15, 2025
app/javascript/components/schedule-form/schedule-form-fields.js
Outdated
Show resolved
Hide resolved
asirvadAbrahamVarghese
force-pushed
the
schedule-form-cypress-refactor
branch
5 times, most recently
from
77cea7d to
a410731
Compare
jrafanie
reviewed
Aug 19, 2025
app/javascript/components/schedule-form/schedule-form-constants.js
Outdated
Show resolved
Hide resolved
asirvadAbrahamVarghese
changed the title
asirvadAbrahamVarghese
force-pushed
the
schedule-form-cypress-refactor
branch
4 times, most recently
from
41f59ff to
ec95d4a
Compare
jrafanie
reviewed
Aug 22, 2025
jrafanie
reviewed
Aug 22, 2025
jrafanie
reviewed
Aug 22, 2025
asirvadAbrahamVarghese
force-pushed
the
schedule-form-cypress-refactor
branch
5 times, most recently
from
9e39c71 to
664322e
Compare
jrafanie
reviewed
Sep 10, 2025
|
|
asirvadAbrahamVarghese
force-pushed
the
schedule-form-cypress-refactor
branch
2 times, most recently
from
824eeea to
d55303b
Compare
asirvadAbrahamVarghese
force-pushed
the
schedule-form-cypress-refactor
branch
from
d55303b to
6aaca9b
Compare
|
@asirvadAbrahamVarghese looks good... is this ready? If so, remove the WIP and let me know. |
asirvadAbrahamVarghese
changed the title
|
All good here, dropped WIP ✅ |
asirvadAbrahamVarghese
force-pushed
the
schedule-form-cypress-refactor
branch
from
6aaca9b to
3476364
Compare
asirvadAbrahamVarghese
force-pushed
the
schedule-form-cypress-refactor
branch
from
3476364 to
93dba3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to refactor schedule form cypress test
accordionItemwithselectAccordionItemcommand@miq-bot assign @GilbertCherrie
@miq-bot add-label cypress
@miq-bot add-label test
@miq-bot add-label refactoring