Revert "Merge pull request #22901 from jrafanie/drop_default_value_for"

This reverts commit c773b2b, reversing changes made to bb72015.
ManageIQ · Feb 29, 2024 · 6a3ef60 · 6a3ef60
1 parent 0804cca
commit 6a3ef60
Show file tree

Hide file tree

Showing 51 changed files with 104 additions and 132 deletions.
diff --git a/app/models/assigned_server_role.rb b/app/models/assigned_server_role.rb
@@ -2,7 +2,7 @@ class AssignedServerRole < ApplicationRecord
   belongs_to :miq_server
   belongs_to :server_role
 
-  attribute :active, :default => false
+  default_value_for :active, false
 
   delegate :master_supported?, :name, :to => :server_role
 

diff --git a/app/models/blacklisted_event.rb b/app/models/blacklisted_event.rb
@@ -1,11 +1,10 @@
 class BlacklistedEvent < ApplicationRecord
   belongs_to        :ext_management_system, :foreign_key => "ems_id"
 
-  attribute :enabled, :default => true
-  after_validation  :log_enabling, :if => :enabled_changed?, :unless => :new_record?
-  after_create      :audit_creation
-  after_destroy     :reload_all_server_settings, :audit_deletion
+  default_value_for :enabled, true
   after_save        :reload_all_server_settings
+  after_destroy     :reload_all_server_settings, :audit_deletion
+  after_create      :audit_creation
 
   def audit_deletion
     $audit_log.info("Blacklisted event [#{event_name}] for provider [#{provider_model}] with ID [#{ems_id}] has been deleted by user [#{self.class.current_userid}]")
@@ -15,8 +14,11 @@ def audit_creation
     $audit_log.info("Creating blacklisted event [#{event_name}] for provider [#{provider_model}] with ID [#{ems_id}] by user [#{self.class.current_userid}]")
   end
 
-  def log_enabling
-    $audit_log.info("Blacklisted event [#{event_name}] for provider [#{provider_model}] with ID [#{ems_id}] had enabled changed to #{enabled} by user [#{self.class.current_userid}]")
+  def enabled=(value)
+    return if enabled == value
+
+    super
+    $audit_log.info("Blacklisted event [#{event_name}] for provider [#{provider_model}] with ID [#{ems_id}] had enabled changed to #{value} by user [#{self.class.current_userid}]")
   end
 
   def self.seed

diff --git a/app/models/classification.rb b/app/models/classification.rb
@@ -35,10 +35,10 @@ class Classification < ApplicationRecord
 
   DEFAULT_NAMESPACE = "/managed".freeze
 
-  attribute :read_only,    :default => false
-  attribute :syntax,       :default => "string"
-  attribute :single_value, :default => false
-  attribute :show,         :default => true
+  default_value_for :read_only,    false
+  default_value_for :syntax,       "string"
+  default_value_for :single_value, false
+  default_value_for :show,         true
 
   FIXTURE_FILE = FIXTURE_DIR.join("classifications.yml")
 

diff --git a/app/models/cloud_database_flavor.rb b/app/models/cloud_database_flavor.rb
@@ -8,7 +8,7 @@ class CloudDatabaseFlavor < ApplicationRecord
 
   virtual_total :total_cloud_databases, :cloud_databases
 
-  attribute :enabled, :default => true
+  default_value_for :enabled, true
 
   scope :active, -> { where(:enabled => true) }
 end
diff --git a/app/models/dialog.rb b/app/models/dialog.rb
@@ -4,7 +4,7 @@ class Dialog < ApplicationRecord
   # The following gets around a glob symbolic link issue
   YAML_FILES_PATTERN = "{,*/**/}*.{yaml,yml}".freeze
 
-  attribute :system, :default => false
+  default_value_for :system, false
   has_many :dialog_tabs, -> { order(:position) }, :dependent => :destroy
   validate :validate_children
 

diff --git a/app/models/dialog_field.rb b/app/models/dialog_field.rb
@@ -29,10 +29,10 @@ class DialogField < ApplicationRecord
   validates :name, :exclusion => {:in      => %w(action controller),
                                   :message => "Field Name %{value} is reserved."}
 
-  attribute :required, :default => false
-  attribute :visible,  :default => true
+  default_value_for :required, false
+  default_value_for(:visible) { true }
   validates :visible, inclusion: { in: [ true, false ] }
-  attribute :load_values_on_init, :default => true
+  default_value_for :load_values_on_init, true
 
   serialize :values
   serialize :values_method_options,   Hash

diff --git a/app/models/endpoint.rb b/app/models/endpoint.rb
@@ -3,7 +3,7 @@
 class Endpoint < ApplicationRecord
   belongs_to :resource, :polymorphic => true
 
-  attribute :verify_ssl, :default => OpenSSL::SSL::VERIFY_PEER
+  default_value_for :verify_ssl, OpenSSL::SSL::VERIFY_PEER
   validates :verify_ssl, :inclusion => {:in => [OpenSSL::SSL::VERIFY_NONE, OpenSSL::SSL::VERIFY_PEER]}
   validates :port, :numericality => {:only_integer => true, :allow_nil => true, :greater_than => 0}
   validates :url, :uniqueness_when_changed => true, :allow_blank => true, :unless => :allow_duplicate_url?

diff --git a/app/models/ext_management_system.rb b/app/models/ext_management_system.rb
@@ -306,7 +306,7 @@ def validate_zone_not_maintenance_when_ems_enabled?
   alias_method :clusters, :ems_clusters # Used by web-services to return clusters as the property name
   alias_attribute :to_s, :name
 
-  attribute :enabled, :default => true
+  default_value_for :enabled, true
 
   # Move ems to maintenance zone and backup current one
   # @param orig_zone [Integer] because of zone of child manager can be changed by parent manager's ensure_managers() callback

diff --git a/app/models/flavor.rb b/app/models/flavor.rb
@@ -12,7 +12,7 @@ class Flavor < ApplicationRecord
 
   virtual_total :total_vms, :vms
 
-  attribute :enabled, :default => true
+  default_value_for :enabled, true
 
   alias_attribute :cpus, :cpu_total_cores
   alias_attribute :cpu_cores, :cpu_cores_per_socket

diff --git a/app/models/git_repository.rb b/app/models/git_repository.rb
@@ -11,7 +11,7 @@ class GitRepository < ApplicationRecord
 
   validates :url, :format => Regexp.union(URI.regexp(%w[http https file ssh]), /\A[-\w:.]+@.*:/), :allow_nil => false
 
-  attribute :verify_ssl, :default => OpenSSL::SSL::VERIFY_PEER
+  default_value_for :verify_ssl, OpenSSL::SSL::VERIFY_PEER
   validates :verify_ssl, :inclusion => {:in => [OpenSSL::SSL::VERIFY_NONE, OpenSSL::SSL::VERIFY_PEER]}
 
   has_many :git_branches, :dependent => :destroy

diff --git a/app/models/manageiq/providers/cloud_manager/template.rb b/app/models/manageiq/providers/cloud_manager/template.rb
@@ -1,5 +1,5 @@
 class ManageIQ::Providers::CloudManager::Template < ::MiqTemplate
-  attribute :cloud, :default => true
+  default_value_for :cloud, true
 
   virtual_column :image?, :type => :boolean
 

diff --git a/app/models/manageiq/providers/cloud_manager/vm.rb b/app/models/manageiq/providers/cloud_manager/vm.rb
@@ -26,7 +26,7 @@ class ManageIQ::Providers::CloudManager::Vm < ::Vm
 
   has_many   :host_aggregates,        :through => :host
 
-  attribute :cloud, :default => true
+  default_value_for :cloud, true
 
   virtual_column :ipaddresses, :type => :string_set, :uses => {:network_ports => :ipaddresses}
   virtual_column :floating_ip_addresses, :type => :string_set, :uses => {:network_ports => :floating_ip_addresses}

diff --git a/app/models/manageiq/providers/embedded_automation_manager/configuration_script_source.rb b/app/models/manageiq/providers/embedded_automation_manager/configuration_script_source.rb
@@ -11,8 +11,8 @@ class ManageIQ::Providers::EmbeddedAutomationManager::ConfigurationScriptSource
   validates :scm_type,   :presence => true, :inclusion => {:in => %w[git]}
   validates :scm_branch, :presence => true
 
-  attribute :scm_type, :default => "git"
-  attribute :scm_branch, :default => "master"
+  default_value_for :scm_type,   "git"
+  default_value_for :scm_branch, "master"
 
   belongs_to :git_repository, :autosave => true, :dependent => :destroy
   before_validation :sync_git_repository

diff --git a/app/models/manageiq/providers/infra_manager/template.rb b/app/models/manageiq/providers/infra_manager/template.rb
@@ -1,5 +1,5 @@
 class ManageIQ::Providers::InfraManager::Template < MiqTemplate
-  attribute :cloud, :default => false
+  default_value_for :cloud, false
 
   def self.display_name(number = 1)
     n_('Template', 'Templates', number)

diff --git a/app/models/manageiq/providers/infra_manager/vm.rb b/app/models/manageiq/providers/infra_manager/vm.rb
@@ -1,5 +1,5 @@
 class ManageIQ::Providers::InfraManager::Vm < ::Vm
-  attribute :cloud, :default => false
+  default_value_for :cloud, false
 
   # Show certain non-generic charts
   def cpu_mhz_available?

diff --git a/app/models/manageiq/providers/physical_infra_manager/vm.rb b/app/models/manageiq/providers/physical_infra_manager/vm.rb
@@ -1,5 +1,5 @@
 class ManageIQ::Providers::PhysicalInfraManager::Vm < ::Vm
-  attribute :cloud, :default => false
+  default_value_for :cloud, false
 
   def self.display_name(number = 1)
     n_('Virtual Machine', 'Virtual Machines', number)

diff --git a/app/models/miq_ae_method.rb b/app/models/miq_ae_method.rb
@@ -5,7 +5,7 @@ class MiqAeMethod < ApplicationRecord
   include MiqAeYamlImportExportMixin
   include RelativePathMixin
 
-  attribute :embedded_methods, :default => -> { [] }
+  default_value_for(:embedded_methods) { [] }
   # switch back to validates :exclusion once rails 6.1 issue is fixed
   # https://github.com/rails/rails/issues/41051
   validate :embedded_methods_not_nil

diff --git a/app/models/miq_approval.rb b/app/models/miq_approval.rb
@@ -3,7 +3,7 @@ class MiqApproval < ApplicationRecord
   belongs_to :stamper,  :class_name => "User"
   belongs_to :miq_request
 
-  attribute :state, :default => "pending"
+  default_value_for :state, "pending"
 
   def approver=(approver)
     super

diff --git a/app/models/miq_group.rb b/app/models/miq_group.rb
@@ -32,8 +32,9 @@ class MiqGroup < ApplicationRecord
 
   serialize :settings
 
-  attribute :group_type, :default => USER_GROUP
-  attribute :sequence, :default => -> { next_sequence }
+  default_value_for :group_type, USER_GROUP
+  default_value_for(:sequence) { next_sequence }
+
   acts_as_miq_taggable
   include CustomAttributeMixin
   include ActiveVmAggregationMixin
@@ -80,7 +81,7 @@ def self.next_sequence
     #   https://github.com/rails/rails/pull/35280
     #
     # This was an attempt to fix "leaking scopes", however, in our case, we use
-    # this method both for our default value of :sequence, and it will get
+    # this method both for our +default_value_for(:sequence)+, and it will get
     # used as part of +.create_tenant_group+.
     #
     # As such, we need both +.current_scope+ for when we want to scope down the

diff --git a/app/models/miq_policy.rb b/app/models/miq_policy.rb
@@ -35,9 +35,9 @@ def self.policy_modes
   include YamlImportExportMixin
   before_validation :default_name_to_guid, :on => :create
 
-  attribute :towhat, :default => 'Vm'
-  attribute :active, :default => true
-  attribute :mode,   :default => 'control'
+  default_value_for :towhat, 'Vm'
+  default_value_for :active, true
+  default_value_for :mode,   'control'
 
   # NOTE: If another class references MiqPolicy through an ActiveRecord association,
   #   particularly has_one and belongs_to, calling .conditions will result in

diff --git a/app/models/miq_provision_request.rb b/app/models/miq_provision_request.rb
@@ -16,19 +16,15 @@ class MiqProvisionRequest < MiqRequest
   validates :source, :presence => true
   validate               :must_have_user
 
+  default_value_for :options,      :number_of_vms => 1
   default_value_for(:source_id)    { |r| r.get_option(:src_vm_id) || r.get_option(:source_id) }
-  attribute :source_type, :default => "VmOrTemplate"
+  default_value_for :source_type,  "VmOrTemplate"
 
   virtual_column :provision_type, :type => :string
 
   include MiqProvisionMixin
   include MiqProvisionQuotaMixin
 
-  # Setup default coming back from the default serialized Hash
-  def options
-    super.tap { |s| s[:number_of_vms] = 1 unless s.key?(:number_of_vms) }
-  end
-
   def self.request_task_class_from(attribs)
     source_id = MiqRequestMixin.get_option(:src_vm_id, nil, attribs['options'])
     vm_or_template = source_vm_or_template!(source_id)

diff --git a/app/models/miq_request.rb b/app/models/miq_request.rb
@@ -25,10 +25,11 @@ class MiqRequest < ApplicationRecord
   serialize   :options, Hash
 
   default_value_for(:message)       { |r| "#{r.class::TASK_DESCRIPTION} - Request Created" }
-  attribute :request_state, :default => 'pending'
+  default_value_for :options,       {}
+  default_value_for :request_state, 'pending'
   default_value_for(:request_type)  { |r| r.request_types.first }
-  attribute :status,  :default => 'Ok'
-  attribute :process, :default => true
+  default_value_for :status,        'Ok'
+  default_value_for :process,       true
 
   validates_inclusion_of :approval_state, :in => %w(pending_approval approved denied), :message => "should be 'pending_approval', 'approved' or 'denied'"
   validates_inclusion_of :status,         :in => %w(Ok Warn Error Timeout Denied)

diff --git a/app/models/miq_request_task.rb b/app/models/miq_request_task.rb
@@ -13,8 +13,10 @@ class MiqRequestTask < ApplicationRecord
   serialize   :phase_context, Hash
   serialize   :options,       Hash
 
-  attribute :state, :default => 'pending'
-  attribute :status, :default => 'Ok'
+  default_value_for :phase_context, {}
+  default_value_for :options,       {}
+  default_value_for :state,         'pending'
+  default_value_for :status,        'Ok'
 
   delegate :request_class, :task_description, :to => :class
 

diff --git a/app/models/miq_schedule.rb b/app/models/miq_schedule.rb
@@ -44,9 +44,9 @@ class MiqSchedule < ApplicationRecord
   ALLOWED_CLASS_METHOD_ACTIONS = %w[automation_request].freeze
   IMPORT_CLASS_NAMES = %w[MiqSchedule].freeze
 
-  attribute :userid, :default => "system"
-  attribute :enabled, :default => true
-  attribute :zone_id, :default => -> { MiqServer.my_server.zone_id }
+  default_value_for :userid,  "system"
+  default_value_for :enabled, true
+  default_value_for(:zone_id) { MiqServer.my_server.zone_id }
 
   def set_start_time_and_prod_default
     run_at # Internally this will correct :start_time to UTC

diff --git a/app/models/miq_server.rb b/app/models/miq_server.rb
@@ -25,8 +25,8 @@ class MiqServer < ApplicationRecord
   before_destroy          :validate_is_deleteable
   after_destroy           :destroy_linked_events_queue
 
-  attribute :name, :default => "EVM"
-  attribute :zone, :default => -> { Zone.default_zone }
+  default_value_for(:name, "EVM")
+  default_value_for(:zone) { Zone.default_zone }
 
   scope :active_miq_servers, -> { where(:status => STATUSES_ACTIVE) }
   scope :recently_active,    -> { where(:last_heartbeat => 10.minutes.ago.utc...Time.now.utc) }

diff --git a/app/models/miq_user_role.rb b/app/models/miq_user_role.rb
@@ -14,7 +14,7 @@ class MiqUserRole < ApplicationRecord
 
   serialize :settings
 
-  attribute :read_only, :default => false
+  default_value_for :read_only, false
 
   FIXTURE_PATH = File.join(FIXTURE_DIR, table_name)
   FIXTURE_YAML = "#{FIXTURE_PATH}.yml"

diff --git a/app/models/miq_widget.rb b/app/models/miq_widget.rb
@@ -4,8 +4,8 @@
 class MiqWidget < ApplicationRecord
   include ReadOnlyMixin
 
-  attribute :enabled, :default => true
-  attribute :read_only, :default => false
+  default_value_for :enabled, true
+  default_value_for :read_only, false
 
   DEFAULT_ROW_COUNT = 5
   IMPORT_CLASS_NAMES = %w(MiqWidget).freeze

diff --git a/app/models/notification.rb b/app/models/notification.rb
@@ -16,6 +16,7 @@ class Notification < ApplicationRecord
   before_save :backup_subject_name
 
   serialize :options, Hash
+  default_value_for(:options) { Hash.new }
 
   validate :complete_bindings
 

diff --git a/app/models/notification_recipient.rb b/app/models/notification_recipient.rb
@@ -1,7 +1,7 @@
 class NotificationRecipient < ApplicationRecord
   belongs_to :notification
   belongs_to :user
-  attribute :seen, :default => false
+  default_value_for :seen, false
   virtual_column :details, :type => :string
 
   scope :unseen, -> { where(:seen => false) }

diff --git a/app/models/orchestration_stack_retire_task.rb b/app/models/orchestration_stack_retire_task.rb
@@ -1,5 +1,5 @@
 class OrchestrationStackRetireTask < MiqRetireTask
-  attribute :request_type, :default => "orchestration_stack_retire"
+  default_value_for :request_type, "orchestration_stack_retire"
 
   def self.base_model
     OrchestrationStackRetireTask

diff --git a/app/models/orchestration_template.rb b/app/models/orchestration_template.rb
@@ -8,8 +8,8 @@ class OrchestrationTemplate < ApplicationRecord
   has_many :stacks, :class_name => "OrchestrationStack"
   has_one :picture, :dependent => :destroy, :as => :resource, :autosave => true
 
-  attribute :draft, :default => false
-  attribute :orderable, :default => true
+  default_value_for :draft, false
+  default_value_for :orderable, true
 
   validates :md5,
             :uniqueness_when_changed => {:scope => :draft, :message => "of content already exists (content must be unique)"},

diff --git a/app/models/pxe_server.rb b/app/models/pxe_server.rb
@@ -5,7 +5,7 @@ class PxeServer < ApplicationRecord
 
   alias_attribute :description, :name
 
-  attribute :customization_directory, :default => ""
+  default_value_for :customization_directory, ""
 
   serialize :visibility
 

diff --git a/app/models/service.rb b/app/models/service.rb
@@ -89,10 +89,10 @@ class Service < ApplicationRecord
 
   validates :name, :presence => true
 
-  attribute :visible, :default => false
-  attribute :initiator, :default => 'user'
-  attribute :lifecycle_state, :default => 'unprovisioned'
-  attribute :retired, :default => false
+  default_value_for :visible, false
+  default_value_for :initiator, 'user'
+  default_value_for :lifecycle_state, 'unprovisioned'
+  default_value_for :retired, false
 
   validates :visible, :inclusion => { :in => [true, false] }
   validates :retired, :inclusion => { :in => [true, false] }

diff --git a/app/models/service_reconfigure_request.rb b/app/models/service_reconfigure_request.rb
@@ -9,7 +9,7 @@ class ServiceReconfigureRequest < MiqRequest
   virtual_has_one :provision_dialog
 
   default_value_for(:source_id)    { |r| r.get_option(:src_id) }
-  attribute :source_type, :default => SOURCE_CLASS_NAME
+  default_value_for :source_type,  SOURCE_CLASS_NAME
 
   def my_role(_action = nil)
     'ems_operations'

diff --git a/app/models/service_resource.rb b/app/models/service_resource.rb
@@ -10,10 +10,10 @@ class ServiceResource < ApplicationRecord
   belongs_to :resource, :polymorphic => true
   belongs_to :source,   :polymorphic => true
 
-  attribute :group_idx,       :default => 0
-  attribute :scaling_min,     :default => 1
-  attribute :scaling_max,     :default => -1
-  attribute :provision_index, :default => 0
+  default_value_for :group_idx, 0
+  default_value_for :scaling_min, 1
+  default_value_for :scaling_max, -1
+  default_value_for :provision_index, 0
 
   virtual_column :resource_name,        :type => :string
   virtual_column :resource_description, :type => :string