Merge pull request #19053 from Fryguy/blacklist_permissions_store

Convert Vmdb::PermissionsStore to a blacklist

lib/vmdb/permission_stores/yaml.rb

@@ -8,11 +8,11 @@ def self.create(config)
 
     class YAML
       def initialize(file)
-        @permissions = Psych.load_file(file)
+        @blacklist = Psych.load_file(file)
       end
 
       def can?(permission)
-        @permissions.include?(permission)
+        !@blacklist.include?(permission)
       end
 
       def supported_ems_type?(type)

spec/lib/vmdb/permission_stores_spec.rb

@@ -49,15 +49,15 @@
 
   describe '::YAML' do
     it '#can?' do
-      stub_vmdb_permission_store_with_types(["foo"]) do
+      stub_vmdb_permission_store_with_types(["bar"]) do
         instance = Vmdb::PermissionStores.instance
         expect(instance.can?('foo')).to be_truthy
         expect(instance.can?('bar')).to be_falsey
       end
     end
 
     it '#supported_ems_type?' do
-      stub_vmdb_permission_store_with_types(["ems-type:foo"]) do
+      stub_vmdb_permission_store_with_types(["ems-type:bar"]) do
         instance = Vmdb::PermissionStores.instance
         expect(instance.supported_ems_type?('foo')).to be_truthy
         expect(instance.supported_ems_type?('bar')).to be_falsey

spec/models/ext_management_system_spec.rb

@@ -97,14 +97,7 @@
 
     it "with removed permissions" do
       stub_vmdb_permission_store_with_types(["ems-type:vmwarews"]) do
-        expect(described_class.supported_types_and_descriptions_hash).to eq("vmwarews" => "VMware vCenter")
-      end
-    end
-
-    it "permissions.tmpl.yml should contain all EMS types" do
-      types = YAML.load_file(Rails.root.join("config/permissions.tmpl.yml"))
-      stub_vmdb_permission_store_with_types(types) do
-        expect(described_class.supported_types_and_descriptions_hash).to eq(all_types_and_descriptions)
+        expect(described_class.supported_types_and_descriptions_hash).to_not include("vmwarews")
       end
     end
   end