Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring available_tenants method for miq_ae_orchestrations. #12142

Merged
merged 2 commits into from
Oct 26, 2016
Merged

Refactoring available_tenants method for miq_ae_orchestrations. #12142

merged 2 commits into from
Oct 26, 2016

Conversation

pkomanek
Copy link
Contributor

@pkomanek pkomanek commented Oct 24, 2016

Purpose or Intent

Refactoring available_tenants method for miq_ae_orchestration based on the issue bellow.

Links [Optional]

#12038

@pkomanek
Copy link
Contributor Author

Working on the specs.

@miq-bot
Copy link
Member

miq-bot commented Oct 24, 2016

@pkomanek unrecognized command 'add_lables', ignoring...

Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone

@pkomanek
Copy link
Contributor Author

@miq-bot add_labels wip, automate, enhancement

@mkanoor
Copy link
Contributor

mkanoor commented Oct 24, 2016

@pkomanek Travis failed, also can we change the specs so that they can be independent of the automation engine. This PR #11753 has a sample method and spec.

@pkomanek
Copy link
Contributor Author

@mkanoor thanks for review, I know about refactoring spec and I am working on that. It will be done tomorrow.

@pkomanek
Copy link
Contributor Author

@miq-bot remove_label wip

@pkomanek pkomanek changed the title [WIP] Refactoring available_tenants method for miq_ae_orchestrations. Refactoring available_tenants method for miq_ae_orchestrations. Oct 24, 2016
@miq-bot miq-bot removed the wip label Oct 24, 2016
@miq-bot
Copy link
Member

miq-bot commented Oct 24, 2016

Checked commits pkomanek/manageiq@f1bce23~...c0db74a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 👍

@mkanoor mkanoor merged commit 5c313dc into ManageIQ:master Oct 26, 2016
@pkomanek pkomanek deleted the refactoring_available_tenants branch October 26, 2016 18:25
@chessbyte chessbyte added this to the Sprint 49 Ending Nov 14, 2016 milestone Oct 27, 2016
@chessbyte
Copy link
Member

@mkanoor @gmcculloug euwe/yes or euwe/no please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants