Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Overview Utilization menu text #19062

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Refactor Overview Utilization menu text #19062

merged 1 commit into from
Aug 1, 2019

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Jul 26, 2019 •
edited
Loading

Refactor Utilization menu to be listed under Overview.

https://bugzilla.redhat.com/show_bug.cgi?id=1729136

Screen shot of Utilization menu prior to code fix:
Utilization menu under Cloud Intel prior to code fix

Screen shot of Utilization menu listed under Overview main menu post code fix:
Utilization menu under Overview post code fix

@GregP GregP changed the title Add Red Hat Cloud menus and refactor Utilization menu text [WIP] Add Red Hat Cloud menus and refactor Utilization menu text Jul 26, 2019
@miq-bot miq-bot added the wip label Jul 26, 2019
@miq-bot
Copy link
Member

miq-bot commented Jul 26, 2019

Checked commits GregP/manageiq@e3079f1~...159d256 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@GregP GregP changed the title [WIP] Add Red Hat Cloud menus and refactor Utilization menu text Add Red Hat Cloud menus and refactor Utilization menu text Jul 26, 2019
@miq-bot miq-bot removed the wip label Jul 26, 2019
@GregP GregP mentioned this pull request Jul 29, 2019
Open
Fryguy
Fryguy requested changes Jul 30, 2019
View reviewed changes
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 This does not belong in core ManageIQ as it is part of a CloudForms-only plugin.

If shortcuts are not pluggable they need to be made pluggable first.

Fryguy
Fryguy reviewed Jul 30, 2019
View reviewed changes
db/fixtures/miq_shortcuts.yml
@@ -10,7 +10,7 @@
:rbac_feature_name: miq_report
:startup: true
- :name: miq_capacity_utilization
:description: Cloud Intel / Utilization
:description: Overview / Utilization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pulled out into a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-kataria @bdunne @Fryguy Removed the commit with Red Hat Cloud menus, will mark up and comment the BZ as well. And renamed the PR to reflect only changes to Utilization menu.

@GregP
Copy link
Contributor Author

GregP commented Jul 30, 2019

@Fryguy @bdunne @h-kataria This is similar to another recent change, with Migration menus. Which are also a gem, and those were handled inside the gem code. I think something similar should be done here as well. This is a 2 part PR, first commit should still apply. Second one, for the Red Hat Cloud menus, I can delete for now until we figure out where it belongs. And maybe add a comment to the BZ itself once we reach a decision.

@bdunne
Copy link
Member

bdunne commented Jul 30, 2019

This is a 2 part PR, first commit should still apply.

I'm with @Fryguy , I don't really understand how the first commit is related to this PR

@GregP
Copy link
Contributor Author

GregP commented Jul 31, 2019 •
edited
Loading

@Fryguy @bdunne Its the other way around. Start at Login drop down lists all the miq shortcust, and this is how the BZ started. Red Hat Cloud was a later on "add on" to the BZ. Main reason I am saying that Red Hat Cloud commit should be deleted from the above, and first commit, dealing with refactoring of Utilization menu and main point of the BZ, should stay. I can change PR name to not reference Red Hat Cloud.

@GregP GregP changed the title Add Red Hat Cloud menus and refactor Utilization menu text Refactor Overview Utilization menu text Aug 1, 2019
@GregP GregP force-pushed the add_red_hat_cloud_menus branch from 159d256 to e3079f1 Compare August 1, 2019 18:31
@h-kataria h-kataria self-assigned this Aug 1, 2019
@h-kataria h-kataria added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 1, 2019
@h-kataria h-kataria merged commit 499cb14 into ManageIQ:master Aug 1, 2019
simaishi pushed a commit that referenced this pull request Aug 1, 2019
@h-kataria @simaishi
Merge pull request #19062 from GregP/add_red_hat_cloud_menus
c19e037 
Refactor Overview Utilization menu text

(cherry picked from commit 499cb14)

https://bugzilla.redhat.com/show_bug.cgi?id=1729136
@simaishi
Copy link
Contributor

simaishi commented Aug 1, 2019

Ivanchuk backport details:

$ git log -1
commit c19e03774a708991f520945b8ebe4996ef9f3ce1
Author: Harpreet Kataria <[email protected]>
Date:   Thu Aug 1 15:18:24 2019 -0400

    Merge pull request #19062 from GregP/add_red_hat_cloud_menus
    
    Refactor Overview Utilization menu text
    
    (cherry picked from commit 499cb1489a2f12b5b6636e5fb024af99cce5d2eb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1729136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne left review comments

@Fryguy Fryguy Fryguy requested changes

@h-kataria h-kataria h-kataria approved these changes

Assignees

@h-kataria h-kataria

Labels
bug changelog/yes ivanchuk/backported ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GregP @miq-bot @bdunne @simaishi @Fryguy @h-kataria