Add IBM Cloud to 'eligible_for_provisioning' list #20484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#20483 will have to be merged before this |
chessbyte
reviewed
Aug 26, 2020
| @@ -17,7 +17,8 @@ def self.eligible_for_provisioning | |||
| ManageIQ::Providers::Azure::CloudManager::Template | |||
| ManageIQ::Providers::Google::CloudManager::Template | |||
| ManageIQ::Providers::Openstack::CloudManager::VolumeTemplate | |||
| ManageIQ::Providers::Openstack::CloudManager::VolumeSnapshotTemplate)) | |||
| ManageIQ::Providers::Openstack::CloudManager::VolumeSnapshotTemplate | |||
| ManageIQ::Providers::IbmCloud::PowerVirtualServers::CloudManager::Template)) | |||
There was a problem hiding this comment.
should this list be alphabetized for clarity?
There was a problem hiding this comment.
Done.
I was going to ask if we should also sort Templates from Volume* first, but turns out that comes free :)
Add IBM Cloud Power Virtual Server Template to list of Templates 'eligible_for_provisioning'. Sort items alphabetically.
jaywcarman
force-pushed
the
add_ibm_cloud_eligible_for_provisioning
branch
from
6ab6624 to
4157833
Compare
|
Checked commit jaywcarman@4157833 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
agrare
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IBM Cloud Power Virtual Servers Template to list of Templates
'eligible_for_provisioning' to enable manageiq-providers-ibm_cloud.
This pluggability issue is already included in #19440