-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ibm_vpc to list of ems types #20563
Conversation
7522335
to
65cb258
Compare
Checked commit d-m-u@65cb258 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
@miq-bot add_label bug |
@@ -69,6 +69,7 @@ | |||
"ibm_cloud_power_virtual_servers" => "IBM Power Systems Virtual Servers", | |||
"ibm_cloud_power_virtual_servers_storage" => "IBM Power Systems Virtual Servers Storage", | |||
"ibm_terraform_configuration" => "IBM Terraform Configuration", | |||
"ibm_vpc" => "IBM Virtual Private Cloud", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agrare I'm surprised this isn't ibm_cloud_vpc
(or perhaps ibm_cloud_power_virtual_servers
should be ibm_power_virtual_servers
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also is this in #19440 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah ibm_cloud_vpc would be more consistent and yes we have this tracked there in ExtManagementSystem spec has a test that expects to know every single plugin
Merging to get the specs green |
the addition of the new cloud manager on the ibm provider necessitates a few updated tests
@miq-bot assign @agrare