Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ibm_vpc to list of ems types #20563

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Sep 17, 2020

the addition of the new cloud manager on the ibm provider necessitates a few updated tests

@miq-bot assign @agrare

Failures:

  1) ExtManagementSystem .types
     Failure/Error: expect(described_class.types).to match_array(all_types_and_descriptions.keys)

       expected collection contained:  ["ansible_tower_automation", "azure", "azure_network", "azure_stack", "azure_stack_network", "cinder"...edhat_network", "rhevm", "s3", "scvmm", "swift", "vmware_cloud", "vmware_cloud_network", "vmwarews"]
       actual collection contained:    ["ansible_tower_automation", "azure", "azure_network", "azure_stack", "azure_stack_network", "cinder"...edhat_network", "rhevm", "s3", "scvmm", "swift", "vmware_cloud", "vmware_cloud_network", "vmwarews"]
       the extra elements were:        ["ibm_vpc"]
     # ./spec/models/ext_management_system_spec.rb:96:in `block (2 levels) in <top (required)>'
     # /Users/drewmu/.rvm/gems/ruby-2.5.5/gems/webmock-3.9.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

@miq-bot
Copy link
Member

miq-bot commented Sep 17, 2020

Checked commit d-m-u@65cb258 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 17, 2020

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Sep 17, 2020
@@ -69,6 +69,7 @@
"ibm_cloud_power_virtual_servers" => "IBM Power Systems Virtual Servers",
"ibm_cloud_power_virtual_servers_storage" => "IBM Power Systems Virtual Servers Storage",
"ibm_terraform_configuration" => "IBM Terraform Configuration",
"ibm_vpc" => "IBM Virtual Private Cloud",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare I'm surprised this isn't ibm_cloud_vpc (or perhaps ibm_cloud_power_virtual_servers should be ibm_power_virtual_servers)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is this in #19440 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah ibm_cloud_vpc would be more consistent and yes we have this tracked there in ExtManagementSystem spec has a test that expects to know every single plugin

@agrare agrare merged commit 1e7f51b into ManageIQ:master Sep 18, 2020
@d-m-u d-m-u deleted the fix_ems_type_spec branch September 18, 2020 00:48
@agrare
Copy link
Member

agrare commented Sep 18, 2020

Merging to get the specs green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants