add cloud vpc network to list of ems types #20593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit d-m-u@2844fc0 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
cc @chadh1313 @jaywcarman @agrare - FYI, as we make changes to the IBM providers, we may want to run more cross-repo tests with core. |
jrafanie
approved these changes
Sep 24, 2020
|
@Fryguy we can keep more watch on the cross-repo tests. Going forward, is this list of providers/managers something that can be derived from the plugin framework? |
|
@chadh1313 #20595 should resolve this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the core repo's red currently because of recent ibm provider changes again
@miq-bot add_label bug