Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the .types and .supported_types EMS specs #20595

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 24, 2020

Update the spec test to not require a hard-coded exhaustive list of EMS types from all of the plugins

Any change to ems_type (new manager, change the ems_type name, etc...) will cause master to be red until this core list is updated (e.g. #20593)

I don't think that testing leaf_subclasses.map() is really buying us that much and we can easily test Vmdb::PermissionStores without checking the entire list

#19440

Update the spec test to not require a hard-coded exhaustive list of
EMS types from all of the plugins

ManageIQ#19440
@miq-bot
Copy link
Member

miq-bot commented Sep 24, 2020

Checked commit agrare@fcd17a3 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy Fryguy merged commit a4c1e11 into ManageIQ:master Sep 24, 2020
@Fryguy Fryguy self-assigned this Sep 24, 2020
@Fryguy Fryguy mentioned this pull request Sep 24, 2020
48 tasks
@agrare agrare deleted the refactor_ems_suported_types_spec branch October 19, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants