Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logger initialization and configuration into plugins #20960

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jan 15, 2021

Follow up to #20950
Part of #19440

Depends on

Of note, the following providers do NOT have PRs, because they don't actually use the logger that was defined (or in some cases not defined) in core

  • ManageIQ/manageiq-providers-autosde
  • ManageIQ/manageiq-providers-foreman
  • ManageIQ/manageiq-providers-ibm_terraform
  • ManageIQ/manageiq-providers-kubevirt
  • ManageIQ/manageiq-providers-openshift

(Also, there is no PR for ManageIQ/manageiq-providers-amazon, because it was covered in #20950)

@agrare Please review

@miq-bot
Copy link
Member

miq-bot commented Jan 15, 2021

Checked commit Fryguy@c7ba827 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy mentioned this pull request Jan 15, 2021
48 tasks
@agrare agrare merged commit 9f1a1f4 into ManageIQ:master Jan 16, 2021
@Fryguy Fryguy deleted the pluggable_loggers2 branch January 18, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants