Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle as a vendor and OS Type #21080

Merged
merged 1 commit into from
Feb 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/operating_system.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class OperatingSystem < ApplicationRecord
["linux_coreos", %w(coreos)],
["linux_esx", %w(vmnixx86 vmwareesxserver esxserver vmwareesxi)],
["linux_solaris", %w(solaris)],
["linux_oracle", %w(oracle)],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is Oracle Linux.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we just need a os-linux_oracle icon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can probably symlink like we do for other images.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

["linux_generic", %w(linux)],
["unix_aix", %w(aix)],
["ibm_i", %w(ibmi)]
Expand Down
1 change: 1 addition & 0 deletions app/models/vm_or_template.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class VmOrTemplate < ApplicationRecord
"amazon" => "Amazon",
"redhat" => "RedHat",
"openstack" => "OpenStack",
"oracle" => "Oracle",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, this is Oracle Cloud.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the vendor-oracle.svg is being picked up already
Screenshot from 2021-02-24 14-40-44

"google" => "Google",
"kubevirt" => "KubeVirt",
"ibm" => "IBM",
Expand Down