add prod dirs via .gitkeep

[kbrock]

part of #20394

the flip side in the rpm is: ManageIQ/manageiq-rpm_build#174

These 3 directories need to be in production (and writeable)

They were created by our rpm build process, but moving the here
to keep the logic in a place that is accessible by both pods and appliances.

[miq-bot]

Checked commit kbrock@2b26458 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

[Fryguy]

Is there an associated issue on the rpm build side to stop creating these directories? Also, is there any source code that tries to do like a mkdir -p to create these directories that can now be removed?

[kbrock]

created associated PR that no longer mkdir -p
It does chown them so manageiq user can write to them

WIP: verify the rpm properly creates these directories

[agrare]

Also, is there any source code that tries to do like a mkdir -p to create these directories that can now be removed?

Yes https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ops_controller/settings/common.rb#L6

[kbrock]

YAY -- good find. we are creating them up front but that is a great example of a directory that should be removed

[agrare]

we are creating them up front

Actually that one didn't exist on my appliance and the UI worker was trying to create it when I hit the application settings page. (sorry if you were talking about going to be creating them up front)

[kbrock]

we are creating them up front

Actually that one didn't exist on my appliance and the UI worker was trying to create it when I hit the application settings page. (sorry if you were talking about going to be creating them up front)

Yea, this PR should create those directories with the .gitkeep. Maybe that is a bad assumption, too.

[kbrock]

I wanted to delete https://github.com/ManageIq/manageiq/blob/master/app/models/git_repository.rb#L226

But was getting failed builds that didn't seem totally logical. ref1 ref2
This may be because of the tests cleaning up after themselves. Not totally sure since one environment worked and the other did not. (the ruby version or processor type should not have affected the way a directory was created by git checkout)

Either way, leaving the mkdir in there. at least for now.

[kbrock]

unwip: the dirs show up with correct permissions after an rpm upgrade.