Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MORPHY] Add Oracle Cloud #21408

Closed
wants to merge 2 commits into from
Closed

[MORPHY] Add Oracle Cloud #21408

wants to merge 2 commits into from

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 30, 2021

Backport of oracle cloud provider

#21087
#21080

Fryguy added 2 commits August 30, 2021 09:25
@Fryguy @agrare
Merge pull request ManageIQ#21087 from agrare/add_oracle_cloud
ddccd74 
Add Oracle Cloud provider

(cherry picked from commit fa5dae0)
@Fryguy @agrare
Merge pull request ManageIQ#21080 from agrare/add_oracle_vendor
541e9e7 
Add Oracle as a vendor and OS Type

(cherry picked from commit 633ccf4)
@agrare agrare requested review from Fryguy and kbrock as code owners August 30, 2021 13:37
@agrare
Copy link
Member Author

agrare commented Aug 30, 2021

@miq-bot cross-repo-tests agrare/manageiq-providers-oracle_cloud@morphy

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Aug 30, 2021
@agrare @miq-bot
Running tests for agrare
91bc06e 
From Pull Request:  ManageIQ/manageiq#21408
@miq-bot miq-bot mentioned this pull request Aug 30, 2021
Closed
@miq-bot
Copy link
Member

miq-bot commented Aug 30, 2021

Checked commits agrare/manageiq@ddccd74~...541e9e7 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
5 files checked, 1 offense detected

app/models/operating_system.rb

@agrare
Copy link
Member Author

agrare commented Aug 30, 2021 •
edited
Loading

Proposing https://github.com/agrare/manageiq-providers-oracle_cloud/tree/morphy as a branch point for morphy. It has the initial full refresh, vcr specs, and config/secrets.defaults.yml. We can then start individually labeling morphy/yes? on individual PRs that we want to bring back.

Cross-repo-tests ManageIQ/manageiq-cross_repo-tests#465
(this PR will be red until there is a morphy branch on ManageIQ/manageiq-providers-oracle_cloud)

@agrare
Copy link
Member Author

agrare commented Aug 30, 2021

Okay cross-repo is green

@Fryguy Fryguy closed this Aug 30, 2021
@Fryguy Fryguy reopened this Aug 30, 2021
@Fryguy
Copy link
Member

Fryguy commented Aug 30, 2021

I created the morphy branch on the oracle cloud repo, and rekicked this one.

@Fryguy Fryguy self-assigned this Aug 30, 2021
@agrare
Copy link
Member Author

agrare commented Aug 30, 2021

@Fryguy looks like this is red because we are actually looking for a "lasker" branch on all of these plugins rather than a "morphy" branch.

Fixed in #21409

@Fryguy
Copy link
Member

Fryguy commented Aug 30, 2021 •
edited
Loading

Ahhh interesting. I haven't yet run the new branch automation yet for the new branches (cause I'm still writing it), but I thought the core repo was done already. Let me see if my automation covers this, then I can close that PR.

@agrare agrare mentioned this pull request Aug 31, 2021
Closed
3 tasks
@agrare agrare closed this Aug 31, 2021
@agrare
Copy link
Member Author

agrare commented Aug 31, 2021

Closing as the two PRs could be backported without conflict

@agrare agrare deleted the morphy_add_oracle_cloud branch August 31, 2021 17:23
@chessbyte chessbyte added this to the Morphy milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

@kbrock kbrock Awaiting requested review from kbrock kbrock is a code owner

Assignees

@Fryguy Fryguy

Labels
dependencies enhancement
Projects
None yet
Milestone
Morphy
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @miq-bot @Fryguy @chessbyte