Make MIQ widgets pluggable #22087
Merged
Make MIQ widgets pluggable #22087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Aug 31, 2022
lib/vmdb/plugins.rb
Outdated
Comment on lines
84
to
86
| @miq_widgets_content ||= begin | ||
| Dir.glob(Rails.root.join("product/dashboard/widgets", "*")) + flat_map { |engine| content_directories(engine, "dashboard/widgets") } | ||
| end |
There was a problem hiding this comment.
begin/end isn't needed here since the contents are a single line.
Fryguy
reviewed
Aug 31, 2022
|
Technically, after this PR, we can now probably move all of the dashboard widgets out of core and into either manageiq-ui-classic or manageiq-content. Then we don't need to have the |
|
❤️ Love this change! We probably should add this to the checklist in #19440 also |
nasark
force-pushed
the
miq_widgets_pluggability
branch
2 times, most recently
from
9be5b46 to
069121d
Compare
agrare
reviewed
Aug 31, 2022
Comment on lines
6
to
12
| let(:core_widget_dir) { File.expand_path(File.join(Rails.root, "product/dashboard/widgets")) } | ||
|
|
||
| before do | ||
| EvmSpecHelper.local_miq_server | ||
|
|
||
| MiqReport.seed_report("Vendor and Guest OS") | ||
| MiqWidget.seed_widget("chart_vendor_and_guest_os") | ||
| MiqWidget.sync_from_file(Dir.glob(File.join(core_widget_dir, "*chart_vendor_and_guest_os*")).first) |
There was a problem hiding this comment.
Since this is a single widget and we know the name I think you can just use the full path and drop the glob
let(:widget_path) { Rails.root.join("product/dashboard/widgets/chart_vendor_and_guest_os.yaml") }
MiqWidget.sync_from_file(widget_path)
069121d to
2c8a973
Compare
agrare
approved these changes
Aug 31, 2022
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<manageiq-provider>/content/dashboard/widgets@miq-bot assign @agrare
@miq-bot add_label enhancement