Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove <value> nodes from MiqExpression#to_ruby #23104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Remove <value> nodes from MiqExpression#to_ruby #23104

wants to merge 2 commits into from

Commits on Nov 6, 2024

  1. converge MiqExpression#lenient evaluate and evaluate

    @kbrock
    kbrock committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    12d5b91 View commit details
    Browse the repository at this point in the history

  2. Condition#do_eval takes into account the current record 

    This allows us to use `rec` in the expression and not have to
post evaluate the to_ruby output

Skipped over the associations and the find clauses
Also skipped the hash contexts
    @kbrock
    kbrock committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e9d9f18 View commit details
    Browse the repository at this point in the history