Allow rails 7 gems in gemspec #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jrafanie
changed the title
jrafanie
force-pushed
the
allow_rails_7
branch
from
d74a6cf to
685c412
Compare
jrafanie
changed the title
Add rails 7 tests for ruby 2.7+, drop EOL rails 5
Fixes deprecation in rails 6.1: "primary"` has been deprecated as the `connection_specification_name` for `ActiveRecord::Base` in favor of using `"ActiveRecord::Base"`. This change affects calls to `ActiveRecord::Base.connection_handler.retrieve_connection` and `ActiveRecord::Base.connection_han dler.remove_connection`. If you're calling these methods with `"primary"`, please switch to `"ActiveRecord::Base".
jrafanie
force-pushed
the
allow_rails_7
branch
from
c0af5ee to
bf5b90d
Compare
|
Checked commits jrafanie/ovirt_metrics@430924f~...bf5b90d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint Gemfile
**
spec/spec_helper.rb
|
agrare
approved these changes
Jan 19, 2024
|
Released v3.2.0 with this change |
jrafanie
added a commit
to jrafanie/manageiq-providers-red_hat_virtualization
that referenced
this pull request
Feb 9, 2024
jrafanie
added a commit
to jrafanie/manageiq-providers-ovirt
that referenced
this pull request
Feb 9, 2024
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rails 7 tests for ruby 2.7+, drop EOL rails 5
Fix rails 7 code to use
connection_specification_nameasAR::Baseinstead ofprimary