Rad 5888 meta script to use maintenance event service #22
Conversation
RAD-5888-Example meta script to use maintenance event service
RAD-5888-Create meta-script-to-use-maintenance-event-service.js
|
Please review the file : meta_points_scripts/meta-script-to-use-maintenance-event-service.js |
|
Please review the file : meta_points_scripts/meta-script-to-use-maintenance-event-service.js please neglect the other file : Meta-MaintenanceEvent-Script.js |
| var eventModelClass = new maintenanceEventModel(); | ||
|
|
||
| //RQL related libraries | ||
| var ASTNode = Java.type('net.jazdw.rql.parser.ASTNode'); |
There was a problem hiding this comment.
We should avoid using the same variable names in multiple scopes within the same script. While this code will execute correctly, a user who is not a developer may not understand the concept of variable shadowing and this can be confusing to them.
There are several variable names that are used multiple times including:
- ASTNode
- RQLUtils
- eventInstance
- eventInstanceService
- sumOfActiveMaintenanceEventsCount
| //function to return the active MaintenanceEvent count linked to pointXids | ||
| function getPointXidActiveMaintenanceEvents(pointXid) { | ||
|
|
||
| var sumOfActiveMaintenanceEventsCount = new ArrayList(); |
There was a problem hiding this comment.
This variable name is a little confusing. This variable represents a list of items, not a numerical sum. Choosing a different variable name would improve readability.
| //first check whether this Meta data point has any acitve maintenance events, if has return 0 | ||
| var metapointActiveMtcEventsCount = 0; | ||
| var pointValueSum = 0; | ||
| var MetaPointXid = 'DP_a620e9ab-8760-4177-8c1a-fecea969652f' |
There was a problem hiding this comment.
This XID doesn't have to be linked to a Meta Point, it can be used for any data point. This variable name should be renamed to avoid confusing users.
| var metapointActiveMtcEventsCount = 0; | ||
| var pointValueSum = 0; | ||
| var MetaPointXid = 'DP_a620e9ab-8760-4177-8c1a-fecea969652f' | ||
| var isMetaPointEnabled = RuntimeManager.isDataPointEnabled(MetaPointXid); |
There was a problem hiding this comment.
This XID doesn't have to be linked to a Meta Point, it can be used for any data point. This variable name should be renamed to avoid confusing users.
| var eventInstanceServiceClass = Common.getBean(EventInstanceService.class); | ||
|
|
||
| //first check whether this Meta data point has any acitve maintenance events, if has return 0 | ||
| var metapointActiveMtcEventsCount = 0; |
There was a problem hiding this comment.
This XID doesn't have to be linked to a Meta Point, it can be used for any data point. This variable name should be renamed to avoid confusing users.
| if (activeContextPointCount > 0) { | ||
| return pointValueSum; | ||
| } else { | ||
|
|
No description provided.