Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing graphing and camera #4125

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Typing graphing and camera #4125

wants to merge 15 commits into from

Conversation

henrikmidtiby
Copy link
Contributor

Overview: What does this pull request change?

Adding type annotations for files in mobject/graphing/.* and camera/.*

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 20, 2025
View reviewed changes
manim/mobject/graphing/scale.py
@@ -26,6 +28,12 @@
def __init__(self, custom_labels: bool = False):
self.custom_labels = custom_labels

@overload
def function(self, value: float) -> float: ...

Check notice

Code scanning / CodeQL

Statement has no effect Note

This statement has no effect.
manim/mobject/graphing/scale.py
def function(self, value: float) -> float: ...

@overload
def function(self, value: np.array) -> np.array: ...

Check notice

Code scanning / CodeQL

Statement has no effect Note

This statement has no effect.
manim/mobject/types/image_mobject.py
@@ -14,6 +14,7 @@
from manim.mobject.geometry.shape_matchers import SurroundingRectangle

from ... import config
from ...camera.moving_camera import MovingCamera

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'MovingCamera' may not be defined if module
manim.camera.moving_camera
Loading
is imported before module
manim.mobject.types.image_mobject
Loading
, as the
definition
Loading
of MovingCamera occurs after the cyclic
import
Loading
of manim.mobject.types.image_mobject.
'MovingCamera' may not be defined if module
manim.camera.moving_camera
Loading
is imported before module
manim.mobject.types.image_mobject
Loading
, as the
definition
Loading
of MovingCamera occurs after the cyclic
import
Loading
of manim.mobject.types.image_mobject.
'MovingCamera' may not be defined if module
manim.camera.moving_camera
Loading
is imported before module
manim.mobject.types.image_mobject
Loading
, as the
definition
Loading
of MovingCamera occurs after the cyclic
import
Loading
of manim.mobject.types.image_mobject.
@henrikmidtiby henrikmidtiby force-pushed the Typing_graphing_and_camera branch from 6b8f27d to f767e8a Compare January 21, 2025 07:21
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
manim/camera/camera.py
@@ -29,6 +31,10 @@
from ..utils.iterables import list_difference_update
from ..utils.space_ops import angle_of_vector

if TYPE_CHECKING:
from ..mobject.types.image_mobject import AbstractImageMobject

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'AbstractImageMobject' may not be defined if module
manim.mobject.types.image_mobject
Loading
is imported before module
manim.camera.camera
Loading
, as the
definition
Loading
of AbstractImageMobject occurs after the cyclic
import
Loading
of manim.camera.camera.
'AbstractImageMobject' may not be defined if module
manim.mobject.types.image_mobject
Loading
is imported before module
manim.camera.camera
Loading
, as the
definition
Loading
of AbstractImageMobject occurs after the cyclic
import
Loading
of manim.camera.camera.
'AbstractImageMobject' may not be defined if module
manim.mobject.types.image_mobject
Loading
is imported before module
manim.camera.camera
Loading
, as the
definition
Loading
of AbstractImageMobject occurs after the cyclic
import
Loading
of manim.camera.camera.
'AbstractImageMobject' may not be defined if module
manim.mobject.types.image_mobject
Loading
is imported before module
manim.camera.camera
Loading
, as the
definition
Loading
of AbstractImageMobject occurs after the cyclic
import
Loading
of manim.camera.camera.
'AbstractImageMobject' may not be defined if module
manim.mobject.types.image_mobject
Loading
is imported before module
manim.camera.camera
Loading
, as the
definition
Loading
of AbstractImageMobject occurs after the cyclic
import
Loading
of manim.camera.camera.
manim/mobject/graphing/coordinate_systems.py
return self.point_to_coords(point)

@staticmethod
def _origin_shift(axis_range: Sequence[float]) -> float: ...

Check notice

Code scanning / CodeQL

Statement has no effect Note

This statement has no effect.
manim/mobject/types/image_mobject.py
from manim.typing import StrPath
from manim.typing import PixelArray, StrPath

from ...camera.moving_camera import MovingCamera

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'MovingCamera' may not be defined if module
manim.camera.moving_camera
Loading
is imported before module
manim.mobject.types.image_mobject
Loading
, as the
definition
Loading
of MovingCamera occurs after the cyclic
import
Loading
of manim.mobject.types.image_mobject.
'MovingCamera' may not be defined if module
manim.camera.moving_camera
Loading
is imported before module
manim.mobject.types.image_mobject
Loading
, as the
definition
Loading
of MovingCamera occurs after the cyclic
import
Loading
of manim.mobject.types.image_mobject.
'MovingCamera' may not be defined if module
manim.camera.moving_camera
Loading
is imported before module
manim.mobject.types.image_mobject
Loading
, as the
definition
Loading
of MovingCamera occurs after the cyclic
import
Loading
of manim.mobject.types.image_mobject.
@henrikmidtiby henrikmidtiby marked this pull request as ready for review January 21, 2025 07:27
This was referenced Jan 21, 2025
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@henrikmidtiby