Add type hints and support for arithmetic operators + and - on ValueTracker
#4129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmuenkel
commented
Jan 21, 2025
fmuenkel
force-pushed
the
typing-value-tracker
branch
from
1ab6b56 to
af88adf
Compare
chopan050
approved these changes
Jul 25, 2025
chopan050
changed the title
mobject/valuetracker.py
chopan050
changed the title
mobject/valuetracker.pymobject/value_tracker.py
chopan050
requested changes
Jul 25, 2025
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
chopan050
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
LGTM! Thanks for the changes!
Now that __sub__ and __add__ is implemented, I noticed that we should do the same for __mul__, __truediv__, __floordiv__, __pow__ and __mod__, since their inplace counterparts are implemented. Now, since this is mainly a PR for adding type hints, this should be done in a subsequent PR. Would you like to do that PR as well?
Meanwhile, I'll just approve and merge this PR.
github-project-automation
bot
moved this from 👀 In review
to 👍 To be merged
in Dev Board
|
Sure, I will have a look at it.. |
3 tasks
chopan050
changed the title
mobject/value_tracker.py+ and - on ValueTracker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
valuetracker.py__iadd__()and__isub__()__sub__()to solve mypy error for__isub__()Motivation and Explanation: Why and how do your changes improve the library?
Related to #3375
Reviewer Checklist