Add type hints to mobject/valuetracker.py #4129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmuenkel
commented
Jan 21, 2025
| The value is internally stored as a points array [a, b, 0]. This can be accessed directly | ||
| to represent the value geometrically, see the usage example. | ||
| """ | ||
| def get_value(self) -> complex: # type: ignore [override] |
There was a problem hiding this comment.
Do not know how to resolve this.
Between ValueTracker and ComplexValueTracker, the latter makes more sense as the base class not the other way around, but that would be a large re-write.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
valuetracker.py__iadd__()and__isub__()__sub__()to solve mypy error for__isub__()Motivation and Explanation: Why and how do your changes improve the library?
Related to #3375
Reviewer Checklist