GUI for multistep searches #494
Conversation
| const location = useLocation(); | ||
|
|
||
| // Add function to check if a path is active | ||
| const isPathActive = (path) => { |
| const method = useMethod(); | ||
| const theme = useTheme(); | ||
|
|
||
| const hasLibrary = method.library.path !== ""; |
There was a problem hiding this comment.
should these members of method maybe be renamed (later) to what they are called in config now?
library_path, raw_paths, fasta_paths?
|
|
||
| let message = data.description; | ||
| if (hasRawFiles && !hasLibrary && !hasFasta) { | ||
| message = "Please select a spectral library and FASTA file to enable transfer learning."; |
There was a problem hiding this comment.
from the if I would have assumed
Please select a spectral library and/or FASTA file.```
| {tab === 'files' && <Files />} | ||
| {tab === 'config' && <Config />} | ||
| </Box> | ||
| </Box> | ||
| ) | ||
| } |
There was a problem hiding this comment.
I got this warning when starting up?
| {tab === 'files' && <Files />} | ||
| {tab === 'config' && <Config />} | ||
| </Box> | ||
| </Box> | ||
| ) |
There was a problem hiding this comment.
Not sure if you really wana mess with the folks from The Dark Side ..
| @@ -78,7 +78,7 @@ const MultiSelect = ({ | |||
| <Grid item xs={3} position={'relative'}> | |||
| <Button | |||
| variant="outlined" | |||
| sx={{float: 'right', ml:1, minWidth: "115px"}} | |||
| sx={{float: 'right', ml:1, minWidth: "130px"}} | |||
| disabled={!active} | |||
| onClick={handleSelect}> | |||
| Select Files | |||
There was a problem hiding this comment.
Could this be "Select FASTA file(s).." ? (Likewise: "Output Folder", "Library File")
just a little less mental mapping
| ) | ||
| } | ||
|
|
||
| const Method = () => { |
There was a problem hiding this comment.
a little inconsistency: fasta file is singular with no number (although I selected two)
|
|
||
| const Config = () => { |
There was a problem hiding this comment.
a little weird:
when expanding "Initial search settings" ..
.. "Search output" moves to the left? would have thought that order is preserved..?
This PR introduces a GUI component for the multistep search