Added map-change event for extents #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliyanH
reviewed
Oct 30, 2024
yushan-mu
force-pushed
the
issue-907
branch
2 times, most recently
from
ea7bd4a to
a39cba4
Compare
AliyanH
reviewed
Oct 31, 2024
AliyanH
approved these changes
Oct 31, 2024
|
Also while testing this, discovered a weird bug (#1007), maybe we can take a look at this next |
AliyanH
approved these changes
Nov 4, 2024
| await context.close(); | ||
| }); | ||
|
|
||
| test('Map change event for layers work', async () => { |
There was a problem hiding this comment.
Suggested change
| test('Map change event for layers work', async () => { | |
| test('Map-change event for map-layer dispatched on user interaction', async () => { |
| expect(layerClicked).toBe(2); | ||
| }); | ||
|
|
||
| test('Map change event for sub-layers work', async () => { |
There was a problem hiding this comment.
Suggested change
| test('Map change event for sub-layers work', async () => { | |
| test('Map-change event for map-extent dispatched on user interaction', async () => { |
… checked/unchecked on the layer menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added map-change event for extents, added test cases for map-change events
fixes #907