Enable <map-layer> inline or remote static features #1034
+1,785
−995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First stab at getting rid of processFeatures / _mapmlvectors approach Several test failures related to feature indexing and perhaps other stuff
…creating MapFeatureLayer
map-extent, -tile, -feature to determine zIndex positioning in parent based on how Leaflet layers are created and shared among sibling elements in a sequence Add red/green/blue-tile.png Add setZIndex function to MapFeatureLayer, MapTileLayer, copied from MapExtentLayer. Update MapFeatureLayer, MapExtentLayer, MapTileLayer initialize constructors to set the zIndex if there's an option present for it
Adapt calculatePosition to working within either shadow root or light DOM Un-break and de-flake tests as possible
Clean up map-feature connectedCallback (remove unused bind)
prushforth
force-pushed
the
static-features
branch
from
4ac894d to
24e125f
Compare
added 5 commits
August 13, 2025 08:58
should NOT be disabled.
should NOT be disabled.
prushforth
force-pushed
the
static-features
branch
from
96cb7d9 to
56cd1f7
Compare
prushforth
force-pushed
the
static-features
branch
from
56cd1f7 to
98d9c10
Compare
context, i.e. as child of a <map-layer>, the container for the MapFeatureLayer or the MapTileLayer should be removed from the layer rendered dom; includes basic tests of this for both types of static content. Update ToDo file, index.html to remind me to fix problems with TemplatedFeaturesOrTilesLayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at getting rid of processFeatures / _mapmlvectors approach
Several test failures related to feature indexing and perhaps other stuff