Support the hidden
attribute on the map elements
#620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite an oversight. To support the global
hidden
attribute we have to handle thedisplay
ourselves, otherwise it is overridden by thedisplay: inline-block
declaration that is set for the default display.I chose to use an
!important
declaration because if the authors changes the default fromdisplay: inline-block
(which is used in a:host
selector that has lower specificity than element selectors) tomapml-viewer { display: block }
then useshidden
it'll still bedisplay: block
. And because: jensimmons/cssremedy#71 (comment).