Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the hidden attribute on the map elements #620

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented Dec 1, 2021

Quite an oversight. To support the global hidden attribute we have to handle the display ourselves, otherwise it is overridden by the display: inline-block declaration that is set for the default display.

I chose to use an !important declaration because if the authors changes the default from display: inline-block (which is used in a :host selector that has lower specificity than element selectors) to mapml-viewer { display: block } then uses hidden it'll still be display: block. And because: jensimmons/cssremedy#71 (comment).

@Malvoz Malvoz merged commit 97a43f6 into Maps4HTML:main Dec 2, 2021
@Malvoz Malvoz deleted the hidden-attr branch December 2, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant