Add gcds-map component based on mapml-viewer #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prushforth
force-pushed
the
mapml-viewer-gcds-map
branch
from
3fef7a9 to
20abf3f
Compare
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ds-snc#660) * refactor(gcds-signature): Signature alternative text to be bilingual * Optimize rendering
…snc#662) * chore: synced local '.github/workflows/s3-backup.yml' with remote 'tools/sre_file_sync/s3-backup.yml' * chore: synced local '.github/workflows/export_github_data.yml' with remote 'tools/sre_file_sync/export_github_data.yml' * chore: synced local '.github/workflows/ossf-scorecard.yml' with remote 'tools/sre_file_sync/ossf-scorecard.yml' --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
* build: remove console errors from tests * build: remove react-ssr CSS and gitignore
…s list (cds-snc#666) fix: error summary focusing gcds element from error-links list
prushforth
force-pushed
the
mapml-viewer-gcds-map
branch
from
802dd3a to
b4af354
Compare
* chore: GCDS Components Release * Prep for release --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> Co-authored-by: Ethan Wallace <[email protected]>
…c#665) Add logic to prevent flash on prop change in storybook
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
storybook/fix-setup-controls-link
fix: Allow skipping blocking form submission with validate-on attribute
…snc#674) * refactor: adjust details font sizes and summary + panel padding * chore: update tokens package
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ed files (cds-snc#676) * feat(gcds-file-uploader): Add files prop for ease of access to uploaded files * Add additional logic for manually setting files property * Add first e2e test for uploading files * Add more e2e tests to file-uploader * Run through linter * Fix typo
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…onsive layout (cds-snc#683) fix(gcds-fieldset): Add CSS to allow form components to maintin responsive layout
* refactor: remove focus colour from label, hint and legend * refactor: remove focus text colour from form fields * chore: update tokens package
prushforth
force-pushed
the
mapml-viewer-gcds-map
branch
from
385e1b9 to
faae7b2
Compare
* chore: GCDS Components Release * Prep for release * Add missing canary tags --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> Co-authored-by: Ethan Wallace <[email protected]>
…#695) * refactor: update spacing values in margin + padding props for container, heading, icon, text * refactor: update styles after typography and spacing updates * refactor: rename text size caption to small * fix: fix input size calculation * refactor: adjust breadcrumbs styling * refactor: adjust card styling * refactor: adjust spacing for heading, text + icon in other components * refactor: rename icon size caption to text-small * hopefully last spacing update lol * refactor: update error message + pagination spacing * refactor: update error message margin + search button padding * feat: update token package
* chore: GCDS Components Release * Update CHANGELOG.md * Update .release-please-manifest.json * Update package-lock.json * Update package.json * Update package-lock.json * update package-web changelog * update packages-vue changelog * update packages-react changelog * update packages-react-ssr changelog * update packages-angular changelog * chore: update lerna.json and CHANGELOG.md --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> Co-authored-by: Melanie Boeckmann <[email protected]> Co-authored-by: Daine Trinidad <[email protected]>
* chore: update example to the correct values * update previous release notes with french * update changelog with french translation of the latest release * removed duplicate content * Update french for "change to"... * update to rouge du PFIM
* build: Remove use of lerna * Update tsconfig paths * Scope test script to packages that have tests
refactor: adjust details padding
* First commit: new gcds-notice component * gcds-notice stories * gcds-notice spec and e2e tests * fix CSS + format index.html * Storybook fixes + upodate notice to use section * Update to new tokens package version * PR feedback: Notice formatting + clean up * Remove unused line of CSS * Add missing lang attribute in storybook * PR feedback: fix typos * First version of icon notice * Update notice component to use icon instead of text label * Update spec unit tests * Update icon selection method * Update tokens package * PR feedback * Add new notice-title-tag property * Fix notice-title-tag comment * Add invalid tag value test * Modify internal heading margin-top to new spacing token value * fix: notice heading spacing * Update tokens package version
…#717) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…kit browsers (cds-snc#723) * fix(gcds-pagination): Add tabindex='0' to links to function in webkit * Remove CSS that was causing issues
…snc#725) * chore: synced local '.github/workflows/s3-backup.yml' with remote 'tools/sre_file_sync/s3-backup.yml' * chore: synced local '.github/workflows/export_github_data.yml' with remote 'tools/sre_file_sync/export_github_data.yml' * chore: synced local '.github/workflows/ossf-scorecard.yml' with remote 'tools/sre_file_sync/ossf-scorecard.yml' --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
* refactor: update pagination arrows to match design * chore: update tokens package
…nc#730) fix(gcds-textarea): Properly set value in shadowroot textarea
…snc#724) * fix(gcds-button): Prevent gcdsClick event if button is disabled * Add two e2e tests to show how a disabled button prevents gcdsClick event * Rewrite new tests since the CI doesn't like the old ones
* feat: add grid gap property for more flexibility * chore: update grid readme to include grid + grid-col props * chore: update tokens package * chore: add stories for new grid gap props
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#733) * feat: add grid gap property for more flexibility * chore: update grid readme to include grid + grid-col props * chore: update tokens package * chore: add stories for new grid gap props * chore: separate grid column component into its own directory * chore: update grid readme to include grid + grid-col props * chore: add stories for new grid gap props * chore: separate grid column component into its own directory * chore: improve grid column comments * chore: improve grid column comments
* chore: update grid spacing + test names * chore: add i18n to grid for error message * docs: add translation for grid gap error messages
* chore: GCDS Components Release * Update .release-please-manifest.json * Update packages/react-ssr/CHANGELOG.md * Update packages/react-ssr/package-lock.json * Update packages/react-ssr/package-lock.json * Update main changelog * Update packages/react-ssr/package.json * chore: update react-ssr version * Update CHANGELOG.md --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> Co-authored-by: Melanie Boeckmann <[email protected]> Co-authored-by: Ethan Wallace <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#744) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
prushforth
force-pushed
the
mapml-viewer-gcds-map
branch
2 times, most recently
from
17833e1 to
9a80f0a
Compare
* docs: update title props description to explain usage * docs: update title props description to explain usage
…#749) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…snc#750) * chore: synced local '.github/workflows/s3-backup.yml' with remote 'tools/sre_file_sync/s3-backup.yml' * chore: synced local '.github/workflows/ossf-scorecard.yml' with remote 'tools/sre_file_sync/ossf-scorecard.yml' --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
Dynamically render layers based on passed props Add gcds-map-layer, update gcds-map to use it. Update index.html with example map. Need to figure out how to get a storybook together. Update gcds-map.stories.tsx Add dependency on @maps4html/mapml Updates for gcds-map Remove dep on npm @maps4html/mapml Add <Host>, load mapml-viewer via script tag, per Ethan Wallace suggestion Basic functional story, needs work Sync package.json with upstream Update packages/web/src/components/gcds-map/gcds-map.tsx Use suggested integrity SHA for mapml.js temporarily until it can be included in dist Co-authored-by: Pierre Dubois <[email protected]> Generated packages ? Update default story - overview.mdx is the focus for examples of gcds-map attributes effects. To do: add examples for gcds-map-layer properties, probably by renaming properties.mdx and using that as the menu item for "Map Layer" Add zoomTo method definition to ts class definition Update component render method to get mapml.js from ./dist/gcds/gcds-map Still need to create that or equivalent location during build process Update map to have controls by default Rename layer- to map-layer Add @maps4html/mapml as dependency. Add copy script, update stencil config to invoke copy of mapml artifacts to dist output directory. Get rid of comment in component that is rendering Change default controls from false to true Make mapml a dependency, not a devDependency, since it must be present at runtime / installed with product Revert <layer-> to <map-layer> refactoring, because that code has not been released yet Make copyMapMLFiles.js into a stencil.config.js plugin thingy, in line with other imported plugins. non-idempotency in copy mapml plugin Replace unreliable custom stencil plugin with stencil copy option Make move <script> creation into componentWillLoad lifecycle method, test for it's previous existence. Add ts-loader to devDependencies (maybe this is not correct, but I couldn't get storybook to compile otherwise). Add dist/gcds/gcds-map as static resource directory for storybook. Add caption attribute to gcds-map Rename title to caption. Update @watches to handle one Prop each. Add caption to index.html gcds-map instance Fix a bunch of compile-time errors Update title -> caption in story Change how controls is implemented by stencil to make it consistent with boolean attribute with default of false when not present Attempt to mitigate problems caused by story rendering component many times with each keystroke Make controlslist a multi-select in storybook Update mapml to 0.16.0
component index.html
prushforth
force-pushed
the
mapml-viewer-gcds-map
branch
from
9a80f0a to
163e875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - contribute to this PR using the gh API