Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: biguint take out param in all operations #36

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

MarcosNicolau
Copy link
Owner

Description

  • Refactors biguint in primitive-types to take an *out to which output the result instead of mutating the first param.
  • Checks have been added to account for the different sizes between the numbers.

Copy link

github-actions bot commented Jan 31, 2025

Library Benchmark Name Iterations Total Execution Time Average Execution Time
primitive-types biguint_add random 1024 bits 1000000 1.978888 seconds 0.000002 seconds
primitive-types biguint_sub random 1024 bits 1000000 1.961269 seconds 0.000002 seconds
primitive-types biguint_divmod random 1024 bits 1000000 2.530223 seconds 0.000003 seconds
primitive-types biguint_mul random 1024 bits 1000000 8.963356 seconds 0.000009 seconds
primitive-types biguint_pow random 1024 bits 1000 11.525362 seconds 0.011525 seconds
primitive-types biguint_pow_mod random 1024 bits 10 10.788718 seconds 1.078872 seconds
math random_prime 256 bits 1 1.488539 seconds 1.488539 seconds
math random_prime 512 bits 1 4.735142 seconds 4.735142 seconds
math random_prime 1024 bits 1 66.462939 seconds 66.462939 seconds
math is_prime_solovay_strassen 512 bits prime 1 3.763286 seconds 3.763286 seconds
math is_prime_solovay_strassen 1024 bits prime 1 25.333640 seconds 25.333640 seconds
math jacobi 512 bits prime 1 0.042485 seconds 0.042485 seconds
math jacobi 1024 bits prime 1 0.297019 seconds 0.297019 seconds
digital-signature rsa_key_generation 256 bits 1 0.361755 seconds 0.361755 seconds
digital-signature rsa_key_generation 512 bits 1 2.085149 seconds 2.085149 seconds
digital-signature rsa_key_generation 1024 bits 1 29.227340 seconds 29.227340 seconds

@MarcosNicolau MarcosNicolau merged commit ffea907 into main Jan 31, 2025
2 checks passed
@MarcosNicolau MarcosNicolau deleted the refactor/biguint-out-param branch January 31, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant