Removed unused usings and added viewonly mode

benchmarks/Benchmarks/ImmutableDictionaryLookup.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using System.Linq;
 using BenchmarkDotNet.Attributes;
 

benchmarks/Benchmarks/MemoryCopy.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Diagnostics;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using BenchmarkDotNet.Attributes;

samples/AvaloniaVncClient/Services/ConnectionManager.cs

@@ -3,7 +3,6 @@
 using System.Threading.Tasks;
 using MarcusW.VncClient;
 using MarcusW.VncClient.Avalonia.Adapters.Logging;
-using MarcusW.VncClient.Rendering;
 using Microsoft.Extensions.Logging;
 using Splat;
 

samples/AvaloniaVncClient/Views/Dialogs/EnterPasswordDialog.xaml.cs

@@ -1,4 +1,3 @@
-using Avalonia;
 using Avalonia.Controls;
 using Avalonia.Interactivity;
 using Avalonia.Markup.Xaml;

samples/AvaloniaVncClient/Views/MainWindow.xaml.cs

@@ -1,6 +1,5 @@
 using System.Reactive.Disposables;
 using System.Reactive.Linq;
-using Avalonia;
 using Avalonia.Controls;
 using Avalonia.Input;
 using Avalonia.Interactivity;
@@ -54,13 +53,13 @@ private void InitializeComponent()
 
         private void OnEnableFullscreenButtonClicked(object? sender, RoutedEventArgs e) => SetFullscreenMode(true);
 
-        private void SetFullscreenMode(bool fullscreen)
-        {
-            WindowState = fullscreen ? WindowState.FullScreen : WindowState.Normal;
+       private void SetFullscreenMode(bool fullscreen)
+            {
+                WindowState = fullscreen ? WindowState.FullScreen : WindowState.Normal;
 
-            TopDockPanel.IsVisible = !fullscreen;
-            BottomDockPanel.IsVisible = !fullscreen;
-            RightDockPanel.IsVisible = !fullscreen;
-        }
+                TopDockPanel.IsVisible = !fullscreen;
+                BottomDockPanel.IsVisible = !fullscreen;
+                RightDockPanel.IsVisible = !fullscreen;
+            }
     }
 }

src/MarcusW.VncClient.Avalonia/Conversions.cs

@@ -1,5 +1,4 @@
 using System;
-using System.ComponentModel;
 using Avalonia;
 
 namespace MarcusW.VncClient.Avalonia

src/MarcusW.VncClient.Avalonia/RfbRenderTarget.cs

@@ -6,11 +6,9 @@
 using Avalonia.Media.Imaging;
 using Avalonia.Platform;
 using Avalonia.Threading;
-using MarcusW.VncClient.Avalonia.Adapters;
 using MarcusW.VncClient.Avalonia.Adapters.Rendering;
 using MarcusW.VncClient.Rendering;
 using IRenderTarget = MarcusW.VncClient.Rendering.IRenderTarget;
-using PixelFormat = Avalonia.Platform.PixelFormat;
 
 namespace MarcusW.VncClient.Avalonia
 {

src/MarcusW.VncClient.Avalonia/VncView.KeyInput.cs

@@ -13,7 +13,7 @@ public partial class VncView
         protected override void OnTextInput(TextInputEventArgs e)
         {
             base.OnTextInput(e);
-            if (e.Handled)
+            if (ViewOnly || e.Handled)
                 return;
 
             // Get connection
@@ -39,7 +39,7 @@ protected override void OnTextInput(TextInputEventArgs e)
         protected override void OnKeyDown(KeyEventArgs e)
         {
             base.OnKeyDown(e);
-            if (e.Handled || e.Key == Key.None)
+            if (ViewOnly || e.Handled || e.Key == Key.None)
                 return;
 
             // Send key press
@@ -53,7 +53,7 @@ protected override void OnKeyDown(KeyEventArgs e)
         protected override void OnKeyUp(KeyEventArgs e)
         {
             base.OnKeyUp(e);
-            if (e.Handled || e.Key == Key.None)
+            if (ViewOnly|| e.Handled || e.Key == Key.None)
                 return;
 
             // Send key release
@@ -69,6 +69,9 @@ protected override void OnKeyUp(KeyEventArgs e)
         protected override void OnLostFocus(RoutedEventArgs e)
         {
             base.OnLostFocus(e);
+            if (ViewOnly)
+                return;
+
             ResetKeyPresses();
         }
 

src/MarcusW.VncClient.Avalonia/VncView.MouseInput.cs

@@ -10,7 +10,7 @@ public partial class VncView
         protected override void OnPointerMoved(PointerEventArgs e)
         {
             base.OnPointerMoved(e);
-            if (e.Handled)
+            if (ViewOnly || e.Handled)
                 return;
 
             PointerPoint point = e.GetCurrentPoint(this);
@@ -22,7 +22,7 @@ protected override void OnPointerMoved(PointerEventArgs e)
         protected override void OnPointerPressed(PointerPressedEventArgs e)
         {
             base.OnPointerPressed(e);
-            if (e.Handled)
+            if (ViewOnly || e.Handled)
                 return;
 
             PointerPoint point = e.GetCurrentPoint(this);
@@ -34,7 +34,7 @@ protected override void OnPointerPressed(PointerPressedEventArgs e)
         protected override void OnPointerReleased(PointerReleasedEventArgs e)
         {
             base.OnPointerReleased(e);
-            if (e.Handled)
+            if (ViewOnly || e.Handled)
                 return;
 
             PointerPoint point = e.GetCurrentPoint(this);
@@ -46,7 +46,7 @@ protected override void OnPointerReleased(PointerReleasedEventArgs e)
         protected override void OnPointerWheelChanged(PointerWheelEventArgs e)
         {
             base.OnPointerWheelChanged(e);
-            if (e.Handled)
+            if (ViewOnly || e.Handled)
                 return;
 
             PointerPoint point = e.GetCurrentPoint(this);

src/MarcusW.VncClient.Avalonia/VncView.Sizing.cs

@@ -4,7 +4,6 @@
 using System.Linq;
 using System.Reactive.Disposables;
 using System.Reactive.Linq;
-using System.Reactive.Subjects;
 using Avalonia;
 using Avalonia.Controls;
 using MarcusW.VncClient.Protocol.Implementation.MessageTypes.Outgoing;

src/MarcusW.VncClient.Avalonia/VncView.cs

@@ -1,10 +1,8 @@
 using System;
 using System.Reactive.Disposables;
 using Avalonia;
-using Avalonia.Input;
 using Avalonia.Threading;
 using MarcusW.VncClient.Output;
-using MarcusW.VncClient.Protocol.Implementation.MessageTypes.Outgoing;
 
 namespace MarcusW.VncClient.Avalonia
 {
@@ -16,10 +14,15 @@ public partial class VncView : RfbRenderTarget, IOutputHandler
         /// <summary>
         /// Defines the <see cref="Connection"/> property.
         /// </summary>
-        public static readonly DirectProperty<VncView, RfbConnection?> ConnectionProperty =
-            AvaloniaProperty.RegisterDirect<VncView, RfbConnection?>(nameof(Connection), o => o.Connection, (o, v) => o.Connection = v);
+        public static readonly DirectProperty<VncView, RfbConnection?> ConnectionProperty = AvaloniaProperty.RegisterDirect<VncView, RfbConnection?>(nameof(Connection), o => o.Connection, (o, v) => o.Connection = v);
+
+        /// <summary>
+        /// Defines the <see cref="ViewOnly"/> property.
+        /// </summary>
+        public static readonly DirectProperty<VncView, bool> ViewOnlyProperty = AvaloniaProperty.RegisterDirect<VncView, bool>(nameof(ViewOnly), o => o.ViewOnly, (o, v) => o.ViewOnly = v);
 
         private RfbConnection? _connection;
+        private bool _viewOnly;
 
         // Disposable for cleaning up after connection detaches
         private CompositeDisposable _connectionDetachDisposable = new CompositeDisposable();
@@ -76,6 +79,20 @@ public RfbConnection? Connection
             }
         }
 
+        /// <summary>
+        /// Gets or sets the view only mode
+        /// </summary>
+        public bool ViewOnly
+        {
+            get => _viewOnly;
+            set
+            {
+                _viewOnly = value;
+                if (_viewOnly)
+                    ResetKeyPresses();
+            }
+        }
+
         public VncView()
         {
             InitSizing();
@@ -91,6 +108,9 @@ public virtual void RingBell()
         /// <inheritdoc />
         public virtual void HandleServerClipboardUpdate(string text)
         {
+            if (ViewOnly)
+                return;
+
             Dispatcher.UIThread.Post(async () => {
                 // Copy the text to the local clipboard
                 await Clipboard.Get().SetTextAsync(text).ConfigureAwait(true);

src/MarcusW.VncClient/ConnectParameters.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Net;
 using MarcusW.VncClient.Output;
 using MarcusW.VncClient.Rendering;
 using MarcusW.VncClient.Security;

src/MarcusW.VncClient/PixelFormat.cs

@@ -1,9 +1,5 @@
 using System;
-using System.Buffers.Binary;
-using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
-using MarcusW.VncClient.Protocol;
-using MarcusW.VncClient.Rendering;
 
 namespace MarcusW.VncClient
 {

src/MarcusW.VncClient/Protocol/Implementation/EncodingTypes/Frame/FrameEncodingType.cs

@@ -1,4 +1,3 @@
-using System.Buffers.Binary;
 using System.IO;
 using MarcusW.VncClient.Protocol.EncodingTypes;
 using MarcusW.VncClient.Rendering;

src/MarcusW.VncClient/Protocol/Implementation/EncodingTypes/Frame/RawEncodingType.cs

@@ -2,7 +2,6 @@
 using System.Diagnostics;
 using System.IO;
 using System.Runtime.CompilerServices;
-using System.Threading;
 using MarcusW.VncClient.Protocol.EncodingTypes;
 using MarcusW.VncClient.Rendering;
 

src/MarcusW.VncClient/Protocol/Implementation/EncodingTypes/Frame/ZLibEncodingType.cs

@@ -2,7 +2,6 @@
 using System.Buffers.Binary;
 using System.Diagnostics;
 using System.IO;
-using System.IO.Compression;
 using System.Linq;
 using MarcusW.VncClient.Protocol.EncodingTypes;
 using MarcusW.VncClient.Rendering;

src/MarcusW.VncClient/Protocol/Implementation/EncodingTypes/Frame/ZrleEncodingType.cs

@@ -3,7 +3,6 @@
 using System.Diagnostics;
 using System.IO;
 using System.Runtime.CompilerServices;
-using System.Threading;
 using MarcusW.VncClient.Protocol.EncodingTypes;
 using MarcusW.VncClient.Rendering;
 

src/MarcusW.VncClient/Protocol/Implementation/EncodingTypes/Pseudo/DesktopSizeEncodingType.cs

@@ -3,7 +3,6 @@
 using System.Diagnostics;
 using System.IO;
 using MarcusW.VncClient.Protocol.EncodingTypes;
-using MarcusW.VncClient.Protocol.Implementation.MessageTypes.Incoming;
 using MarcusW.VncClient.Protocol.Implementation.MessageTypes.Outgoing;
 using Microsoft.Extensions.Logging;
 

src/MarcusW.VncClient/Protocol/Implementation/MessageTypes/Incoming/BellMessageType.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Threading;
-using MarcusW.VncClient.Output;
 using MarcusW.VncClient.Protocol.MessageTypes;
 using Microsoft.Extensions.Logging;
 

src/MarcusW.VncClient/Protocol/Implementation/MessageTypes/Incoming/EndOfContinuousUpdatesMessageType.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Threading;
 using MarcusW.VncClient.Protocol.EncodingTypes;
-using MarcusW.VncClient.Protocol.Implementation.MessageTypes.Outgoing;
 using MarcusW.VncClient.Protocol.MessageTypes;
 using Microsoft.Extensions.Logging;
 

src/MarcusW.VncClient/Protocol/Implementation/MessageTypes/Incoming/ServerFenceMessageType.cs

@@ -1,12 +1,9 @@
 using System;
 using System.Buffers.Binary;
-using System.Collections.Immutable;
 using System.Diagnostics;
 using System.IO;
-using System.Linq;
 using System.Threading;
 using MarcusW.VncClient.Protocol.EncodingTypes;
-using MarcusW.VncClient.Protocol.Implementation.EncodingTypes.Pseudo;
 using MarcusW.VncClient.Protocol.Implementation.MessageTypes.Outgoing;
 using MarcusW.VncClient.Protocol.MessageTypes;
 using MarcusW.VncClient.Protocol.Services;

src/MarcusW.VncClient/Protocol/Implementation/MessageTypes/Outgoing/FramebufferUpdateRequestMessageType.cs

@@ -2,7 +2,6 @@
 using System.Buffers.Binary;
 using System.Diagnostics;
 using System.Threading;
-using MarcusW.VncClient.Protocol.Implementation.MessageTypes.Incoming;
 using MarcusW.VncClient.Protocol.MessageTypes;
 
 namespace MarcusW.VncClient.Protocol.Implementation.MessageTypes.Outgoing

src/MarcusW.VncClient/Protocol/Implementation/MessageTypes/Outgoing/PointerEventMessageType.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Buffers.Binary;
-using System.Diagnostics;
 using System.Threading;
 using MarcusW.VncClient.Protocol.MessageTypes;
 

src/MarcusW.VncClient/Protocol/Implementation/MessageTypes/Outgoing/SetDesktopSizeMessageType.cs

@@ -3,7 +3,6 @@
 using System.Collections.Immutable;
 using System.Diagnostics;
 using System.Threading;
-using MarcusW.VncClient.Protocol.EncodingTypes;
 using MarcusW.VncClient.Protocol.MessageTypes;
 
 namespace MarcusW.VncClient.Protocol.Implementation.MessageTypes.Outgoing

src/MarcusW.VncClient/Protocol/Implementation/PixelConversions.cs

@@ -2,7 +2,6 @@
 using System.Buffers.Binary;
 using System.Diagnostics;
 using System.Runtime.CompilerServices;
-using System.Runtime.Intrinsics.X86;
 
 namespace MarcusW.VncClient.Protocol.Implementation
 {

src/MarcusW.VncClient/Protocol/Implementation/SecurityTypes/NoneSecurityType.cs

@@ -1,5 +1,4 @@
 using System;
-using System.ComponentModel;
 using System.Threading;
 using System.Threading.Tasks;
 using MarcusW.VncClient.Protocol.SecurityTypes;

src/MarcusW.VncClient/Protocol/Implementation/SecurityTypes/VncAuthenticationSecurityType.cs

@@ -1,13 +1,11 @@
 using System;
-using System.ComponentModel;
 using System.Diagnostics;
 using System.Security.Cryptography;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 using MarcusW.VncClient.Protocol.SecurityTypes;
 using MarcusW.VncClient.Security;
-using MarcusW.VncClient.Utils;
 
 namespace MarcusW.VncClient.Protocol.Implementation.SecurityTypes
 {

src/MarcusW.VncClient/Protocol/Implementation/Services/Communication/BuiltinZLibInflater.cs

@@ -1,7 +1,5 @@
 using System;
-using System.Collections;
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.IO;
 using System.IO.Compression;
 using System.Threading;

src/MarcusW.VncClient/Protocol/Implementation/Services/Communication/RfbMessageReceiver.cs

@@ -3,13 +3,10 @@
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
-using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
-using MarcusW.VncClient.Protocol.Implementation.MessageTypes.Outgoing;
 using MarcusW.VncClient.Protocol.MessageTypes;
 using MarcusW.VncClient.Protocol.Services;
-using MarcusW.VncClient.Rendering;
 using MarcusW.VncClient.Utils;
 using Microsoft.Extensions.Logging;
 

src/MarcusW.VncClient/Protocol/Implementation/Services/Handshaking/RfbHandshaker.cs

@@ -8,7 +8,6 @@
 using System.Threading.Tasks;
 using MarcusW.VncClient.Protocol.SecurityTypes;
 using MarcusW.VncClient.Protocol.Services;
-using MarcusW.VncClient.Utils;
 using Microsoft.Extensions.Logging;
 
 namespace MarcusW.VncClient.Protocol.Implementation.Services.Handshaking

src/MarcusW.VncClient/Protocol/Implementation/Services/Initialization/RfbInitializer.cs

@@ -6,7 +6,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using MarcusW.VncClient.Protocol.Services;
-using MarcusW.VncClient.Utils;
 using Microsoft.Extensions.Logging;
 
 namespace MarcusW.VncClient.Protocol.Implementation.Services.Initialization

src/MarcusW.VncClient/Protocol/Implementation/Services/Transports/TransportConnector.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Net;
 using System.Net.Sockets;
 using System.Threading;
 using System.Threading.Tasks;