-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Wpf support (control and sample) #12
base: master
Are you sure you want to change the base?
Conversation
I built this for .NET 6... the pipeline uses .NET 3.1. How do you want to proceed? |
Hey @paviad, |
I honestly do not remember, last I touched this project was end of 2021, and I haven't used it since. I'll see if I can find the time to have a look. |
Thanks for taking your time to answer me. In the meantime i found out that the problem was on my side. I mishandled the cancelation token. Your implementation works just as intented. Thanks again for providing a wpf implementation., |
500e1eb
to
a1dff6b
Compare
I've incorporated #26 into my fork at #12 (https://github.com/paviad/MarcusW.VncClient) |
2dbe0d6
to
5147f64
Compare
11fb8b6
to
39299de
Compare
I added an in memory client using the Skia library (Windows) |
Incorporated PR #28 into this one |
Some comments from my end about the sample:
|
Fixed last two issues (error message and interactive password) Regarding auto size, I couldn't reproduce the problem you mention, even though I am using |
Incorporated PR #29 into this one (for Avalonia and Wpf) |
I conformed to the Avalonia example as much as I could, but I gave up trying to learn ReactiveUI so I did not use it at all.