Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZRLE Subencoding 128 incorrectly always assumes 3 bytes per pixel #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -324,17 +324,19 @@ private void ReadRleTile(Stream stream, bool hasTargetFramebuffer, ref Framebuff
{
fixed (byte* bufferPtr = buffer)
{
int bytesPerPixel = cPixelFormat.BytesPerPixel;

// We need to read on demand, because we cannot tell the number of bytes to read in advance
Span<byte> runLengthReadBuffer = stackalloc byte[1];

int pixelsRemaining = tile.Size.Width * tile.Size.Height;
while (pixelsRemaining > 0)
{
// Read pixel data and first run-length byte
stream.ReadAll(buffer.Slice(0, 4));
stream.ReadAll(buffer.Slice(0, bytesPerPixel + 1));

// Calculate run-length
byte runLengthByte = buffer[3];
byte runLengthByte = buffer[bytesPerPixel];
int runLength = runLengthByte + 1;
while (runLengthByte == 255)
{
Expand Down