Feature: shift to multiselect in QuickTag view #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was previously only supported using shift + up/down arrow, not shift and click. |
Marekkon5
approved these changes
Feb 28, 2025
|
Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation to add a range of tracks. Does not implement nuanced UX of platforms e.g. https://stackoverflow.com/a/16530782
It simply gets the previous selection index, and adds anything to the selection between that index and the current click index.
It does not act in combination with ctrlKey click behavior, ctrlKey takes precedence.
See #450 for original ask.
20250225_223850.mp4
In the video we use shift to expand the selection three times, then deselect three tracks with ctrl click, then expand the selection again. I also tested expanding 'up' but didn't include this in the video.