create separate sticky bit command #491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we discovered an issue with test directories with the sticky bit set. To fix it, we updated the command that changes permissions such that it explicitly unsets the sticky bit on all directories in the autotest worker directory before attempting to delete the contents of the directory, as part of other permissions changes required.
However, this prevents the standard permission changes (
ugo+rwX
) from being applied to files within directories.This is an issue if, for example, the tests create their own files and directories and do not explicitly set them to be group executable, because anything within those directories will not be deletable by the
autotst
user.This PR updates the sticky bit change to run as an entirely separate command.
tested against folders copied from instructor files, as well as folders created by the tests themselves, both with and without the sticky bit applied.
Tests need to be written before this PR can be undrafted