Set _env_status earlier when updating settings #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
donny-wong
approved these changes
Apr 2, 2024
pretendWhale
pushed a commit
to pretendWhale/markus-autotesting
that referenced
this pull request
Apr 3, 2024
* Set _env_status earlier when updating settings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After receiving a request to create/update test settings, the autotester uses the
_env_statuskey as a lock to prevent tests from being run while the environment is still being set up. (See #468)However, because
_env_statuswas being set in the server method as part of a job run, there is time between when the create/update settings request is received and the job is executed where new tests could still be run.In the case of creating a new set of test settings, this could result in a
KeyError: _filesin therun_testsserver method.I've changed this so the client is responsible for setting
_env_status, which should prevent test runs from being executed after the initial settings request is processed, regardless of when the job that sets up the test environment is created.