-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskell tester: make stack resolver version a setting #526
haskell tester: make stack resolver version a setting #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donny-wong looks great! I just noticed one issue with the changelog that needs fixing (and one additional issue on re-review).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donny-wong Okay I think this is on the right track but still not aligned with what I'm looking for.
I don't need a "default" LTS version to be specified as a global autotest server setting. I do want a user setting, which is what you added in that PR, so that's good.
Make Stack Resolver a setting. It is a setting in two places. One is in the environment setting, where when we first install the tester, we will install this version in the setting. Second, is on the test settings where the instructor decides on the version. Currently there is only 1 resolver version to choose from. In the future, we will add to the list.
Note:
in the file "server/autotest_server/init.py" we added the following lines:
The reason for this is because when we import the config for the Haskell tester, we require the jsonschema module. This was not already present in the defaultvenv.
2 Testing procedure: