clear files created in tmp after test runs #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donny-wong
approved these changes
Jun 5, 2024
david-yz-liu
reviewed
Jun 7, 2024
| @@ -257,9 +257,13 @@ def _clear_working_directory(tests_path: str, test_username: str) -> None: | |||
| if test_username != getpass.getuser(): | |||
| sticky_cmd = f"sudo -u {test_username} -- bash -c 'chmod -Rf -t {tests_path}'" | |||
| chmod_cmd = f"sudo -u {test_username} -- bash -c 'chmod -Rf ugo+rwX {tests_path}'" | |||
| clean_tmp_cmd = ( | |||
There was a problem hiding this comment.
This is good, just make sure to update the function docstring to note this additional action.
david-yz-liu
approved these changes
Jun 10, 2024
pretendWhale
added a commit
to pretendWhale/markus-autotesting
that referenced
this pull request
Jul 2, 2024
* ensure users are added in GitHub Actions test configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the autotester will create files in
/tmpduring test runs. Currently these are not automatically removed, leading to issues when/tmpbecomes full. This PR adds a cleanup of the/tmpdirectory during test teardown. All files and directories belonging to the current user will be removed at the end of tests.