Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pass passage augmenter module #352

Merged
merged 14 commits into from
Apr 24, 2024
Merged

Add pass passage augmenter module #352

merged 14 commits into from
Apr 24, 2024
+42 −13

Conversation

bwook00
Copy link
Contributor

@bwook00 bwook00 commented Apr 19, 2024

close #339

I've been merging branch #338, so please review pr #347 after it's merged.

bwook00 added 3 commits April 19, 2024 13:38
@bwook00
Implement pass augmenter

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
42b8a60
@bwook00
Merge branch 'Feature/#338' into Feature/#339
51d40fa
@bwook00
Replace slim corpus and module parameter with if inside if
Loading
Loading status checks…
114b570
@bwook00 bwook00 requested a review from vkehfdl1 April 19, 2024 04:59
bwook00 and others added 9 commits April 19, 2024 14:15
@bwook00
delete blank line
Loading
Loading status checks…
5ecddc5
@bwook00
wrong commit
Loading
Loading status checks…
a57c184
@bwook00
change function name
Loading
Loading status checks…
e2f1c36
@bwook00
Merge branch 'main' into Feature/#339
Loading
Loading status checks…
55288fd
@bwook00
Merge branch 'Feature/#338' into Feature/#339
84bccd3
@bwook00
Merge remote-tracking branch 'origin/Feature/#339' into Feature/#339
Loading
Loading status checks…
d96699d
@bwook00
add top_k at test_code
Loading
Loading status checks…
cbe3060
@bwook00
Merge branch 'main' into Feature/#339
Loading
Loading status checks…
981bd51
@vkehfdl1
Merge branch 'main' into Feature/#339
Loading
Loading status checks…
04cb00f
vkehfdl1
vkehfdl1 requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about pass_passage_augmenter do not perform calculating cosine similarity score at the passage augmenter node decorator?
Because it is pass module, I think it is better that after this module's execution, really nothing happens at all.

@bwook00
pass_passage_augmentor do not perform calculating cosine similarity s…
Loading
Loading status checks…
28f5d96 
…core at the passage augmenter node
@bwook00 bwook00 requested a review from vkehfdl1 April 24, 2024 11:37
@vkehfdl1
Merge branch 'main' into Feature/#339
Loading
Loading status checks…
171604f
@vkehfdl1 vkehfdl1 merged commit c7f3f71 into main Apr 24, 2024
4 checks passed
@vkehfdl1 vkehfdl1 deleted the Feature/#339 branch April 24, 2024 15:10
@vkehfdl1 vkehfdl1 mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkehfdl1 vkehfdl1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pass augmenter module
2 participants
@bwook00 @vkehfdl1