Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retrieval and retrieval token metrics to use unaswerable #371

Merged
merged 13 commits into from
Apr 26, 2024
Merged

Fix retrieval and retrieval token metrics to use unaswerable #371

merged 13 commits into from
Apr 26, 2024

Conversation

bwook00
Copy link
Contributor

@bwook00 bwook00 commented Apr 25, 2024

close #368

  • Adding a contrast code when empty gt is encountered in the retrieval metric
  • Adding a fallback code for empty gt in the retrieval content metric
  • Responding to Unanswerable when empty ids are encountered in fetch content

@bwook00 bwook00 requested a review from vkehfdl1 April 25, 2024 14:51
vkehfdl1
vkehfdl1 requested changes Apr 26, 2024
View reviewed changes
autorag/evaluate/metric/retrieval.py Show resolved Hide resolved
autorag/evaluate/metric/retrieval_contents.py Outdated Show resolved Hide resolved
autorag/utils/util.py Outdated Show resolved Hide resolved
autorag/utils/util.py Outdated Show resolved Hide resolved
autorag/utils/util.py Outdated Show resolved Hide resolved
autorag/nodes/passagereranker/run.py Outdated Show resolved Hide resolved
tests/autorag/evaluate/metric/test_retrieval_metric.py Outdated Show resolved Hide resolved
vkehfdl1
vkehfdl1 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwook00 bwook00 merged commit dd842db into main Apr 26, 2024
4 checks passed
@bwook00 bwook00 deleted the Feature/#368 branch April 26, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkehfdl1 vkehfdl1 vkehfdl1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Hotfix] Fix retrieval and retrieval token metrics to use unaswerable
2 participants
@bwook00 @vkehfdl1