Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sacrebleu parameter available in upper stream #549

Merged
merged 8 commits into from
Jul 1, 2024
Merged

Conversation

Eastsidegunn
Copy link
Contributor

No description provided.

@Eastsidegunn Eastsidegunn requested review from vkehfdl1 and bwook00 June 29, 2024 23:03
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus, add some test case that using BLEU new options

autorag/evaluation/metric/generation.py Outdated Show resolved Hide resolved
autorag/evaluation/metric/generation.py Outdated Show resolved Hide resolved
autorag/evaluation/metric/generation.py Show resolved Hide resolved
@vkehfdl1 vkehfdl1 linked an issue Jun 30, 2024 that may be closed by this pull request
@Eastsidegunn Eastsidegunn requested a review from vkehfdl1 June 30, 2024 21:13
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But we still have this problem.
image

Need to fix at #418

@vkehfdl1 vkehfdl1 merged commit 79ff4c7 into main Jul 1, 2024
3 checks passed
@vkehfdl1 vkehfdl1 deleted the Feature/#517 branch July 1, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for BLEU score
3 participants