Make Playwright host configurable #4010
Open
+29
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution. Currently our CI is broken because of bug in statuschecker. I will try to fix CI this week and I will rerun your PR when CI is fixed. By a quick look your code and need looks OK, but I will take a better look when I am able to use bigger screen instead of a mobile. @allcontributors please add @dean4711 for code. |
|
I've put up a pull request to add @dean4711! 🎉 |
|
This fixes #4012 |
|
Looks like there is a bug somewhere and bunch of tests fail. Could you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using robotframework-browser within a VS Code devcontainer on a macOS host with --network host is not possible, since the binding when starting Playwright fails. However, when using 0.0.0.0 as host everything works as expected.
Therefore, this merge request makes the host when starting the playwright process configurable.