-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply FILAMENT_RUNOUT_SENSOR to MKS_UI #22595
base: bugfix-2.1.x
Are you sure you want to change the base?
Apply FILAMENT_RUNOUT_SENSOR to MKS_UI #22595
Conversation
ebc76e2
to
1973222
Compare
Posting here as you requested my answer to your request in issue #22591 to try Marlin with FILAMENT_RUNOUT_SENSOR enabled and configured. By the way, I have tried to use the current sensor software, but as mentioned above the function "runout.reset()" is never called upon pushing the resume button. This needs to be addressed in the integration. Nothing in the "TFT_LVGL_UI" enabled user interface does this reset and as a result the filament sensor run out monitoring function "runout.run()" will never run again until a "m412 r" command is manually executed,(I used Ponterface remote control program to issue the reset), forcing a reset. Also, I discovered from this forum that "M600" can't be called with "TFT_LVGL_UI" set as the 3.5" color TFT touch screen is not supported by the current "M600" implementation. Only the user configured call to "M25" seems to be supported. This just pauses the printer and waits for the resume button to be pushed. No park, no heater timeout or any other "M600" functions are performed(Note: Advanced pause is also not supported.) The M25 pause,(currently required with the "TFT_LVGL_UI" option ), is very confusing to the operator as they may not know why the printer has paused. Also, changing filament while poised above an incomplete model seems destined for disaster. PS: I believe removing the MKS UI filament runout code without consideration of WiFi polling contained within will break WiFi for "TFT_LVGL_UI" option users. |
MKS UI is not our own baby, but is ostensibly maintained by MKS, so this PR is intended to point out what needs to be done to properly implement a controller. I don't anticipate spending a lot of time poring over MKS UI to fix everything that MKS got wrong. Hopefully this PR will get the ball rolling for MKS to fix the issues you cite. |
I just don't want my comments to end up breaking WiFi and filament support for "TFT_LVGL_UI" option users. Thanks for attempting to get it fixed. It would be nice to get full M600 support,(park,advanced pause,temp timeout...) |
Thank you! I have feedback to the engineer. |
f9aa794
to
90cd1ca
Compare
f4c2f00
to
02ae11e
Compare
4cf533b
to
d3b7aa9
Compare
cc92a7a
to
2ded50b
Compare
834dd65
to
ff78ca7
Compare
80cd234
to
3d2b2ca
Compare
ff78ca7
to
eb2a055
Compare
627f8ef
to
20dea22
Compare
08b8579
to
fedc7a0
Compare
fedc7a0
to
39f2d28
Compare
39f2d28
to
d1155ad
Compare
d1155ad
to
0b7a0e2
Compare
0b7a0e2
to
d1a1833
Compare
d1a1833
to
3a62c06
Compare
3a62c06
to
33d09d7
Compare
c624e13
to
e6f1b07
Compare
33d09d7
to
edb6c24
Compare
9c65146
to
4f65466
Compare
edb6c24
to
b40941f
Compare
b40941f
to
f86945a
Compare
c792921
to
37fb26b
Compare
8149fd9
to
c3e9027
Compare
c3e9027
to
a3ff296
Compare
37d77d6
to
aa44542
Compare
a3ff296
to
3ff0869
Compare
3ff0869
to
9e3a014
Compare
Fixes #22591
Partially integrate MKS UI filament runout code with Marlin.
It would be better if it didn't reinvent the wheel and just used the methods in
features/runout.*
, allowing it to also respond toM600
, park the carriage at a configured position, and so on.