Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply FILAMENT_RUNOUT_SENSOR to MKS_UI #22595

Open
wants to merge 2 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

thinkyhead
Copy link
Member

Fixes #22591

Partially integrate MKS UI filament runout code with Marlin.

It would be better if it didn't reinvent the wheel and just used the methods in features/runout.*, allowing it to also respond to M600, park the carriage at a configured position, and so on.

@tvonderhaar
Copy link

Posting here as you requested my answer to your request in issue #22591 to try Marlin with FILAMENT_RUNOUT_SENSOR enabled and configured.

By the way, I have tried to use the current sensor software, but as mentioned above the function "runout.reset()" is never called upon pushing the resume button. This needs to be addressed in the integration. Nothing in the "TFT_LVGL_UI" enabled user interface does this reset and as a result the filament sensor run out monitoring function "runout.run()" will never run again until a "m412 r" command is manually executed,(I used Ponterface remote control program to issue the reset), forcing a reset. Also, I discovered from this forum that "M600" can't be called with "TFT_LVGL_UI" set as the 3.5" color TFT touch screen is not supported by the current "M600" implementation. Only the user configured call to "M25" seems to be supported. This just pauses the printer and waits for the resume button to be pushed. No park, no heater timeout or any other "M600" functions are performed(Note: Advanced pause is also not supported.) The M25 pause,(currently required with the "TFT_LVGL_UI" option ), is very confusing to the operator as they may not know why the printer has paused. Also, changing filament while poised above an incomplete model seems destined for disaster.
Tom V

PS: I believe removing the MKS UI filament runout code without consideration of WiFi polling contained within will break WiFi for "TFT_LVGL_UI" option users.

@thinkyhead
Copy link
Member Author

thinkyhead commented Aug 19, 2021

MKS UI is not our own baby, but is ostensibly maintained by MKS, so this PR is intended to point out what needs to be done to properly implement a controller. I don't anticipate spending a lot of time poring over MKS UI to fix everything that MKS got wrong. Hopefully this PR will get the ball rolling for MKS to fix the issues you cite.

CC: @MKS-Sean @mks-viva @makerbase-mks

@tvonderhaar
Copy link

I just don't want my comments to end up breaking WiFi and filament support for "TFT_LVGL_UI" option users. Thanks for attempting to get it fixed. It would be nice to get full M600 support,(park,advanced pause,temp timeout...)
Tom

@mks-viva
Copy link
Contributor

MKS UI is not our own baby, but is ostensibly maintained by MKS, so this PR is intended to point out what needs to be done to properly implement a controller. I don't anticipate spending a lot of time poring over MKS UI to fix everything that MKS got wrong. Hopefully this PR will get the ball rolling for MKS to fix the issues you cite.

Thank you! I have feedback to the engineer.

@thinkyhead thinkyhead force-pushed the bf2_mks_runout_PR branch 2 times, most recently from 08b8579 to fedc7a0 Compare June 2, 2023 20:06
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 2 times, most recently from 9c65146 to 4f65466 Compare January 26, 2024 00:13
@thisiskeithb thisiskeithb linked an issue Jul 28, 2024 that may be closed by this pull request
1 task
@thinkyhead thinkyhead force-pushed the bf2_mks_runout_PR branch 2 times, most recently from 8149fd9 to c3e9027 Compare September 10, 2024 08:41
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 3 times, most recently from 37d77d6 to aa44542 Compare September 28, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MKS TFT_LVGL_UI does not support relative extrusion
3 participants