Cosmetic changes to DWIN/E3V2 UI's #26980
Open
+722
−870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classicrocker883
force-pushed
the
bugfix-2.1.x-April6
branch
from
0be93c8
to
12a5426
Compare
… into bugfix-2.1.x-April6
|
@classicrocker883 just to let you know, I'm avoiding merging anything with cosmetic changes. The style of Marlin is hard to decipher, and outside of thinkyhead most of us don't really know what changes are welcome. I'm happy to review and merge bug fixes or or other functional changes if their benefit is clear and I understand the change, but the presence of any cosmetic "cleanup" mixed in makes it much harder for me to consider merging. |
|
I also think the title calling this PR "cosmetic" changes is incomplete. It seems like you have several other improvements (or at least changes) mixed in with the truly cosmetic changes, which would be nice to evaluate on their own. |
classicrocker883
changed the title
… into bugfix-2.1.x-April6
… into bugfix-2.1.x-April6
classicrocker883
changed the title
|
This PR is ready for merge |
… into bugfix-2.1.x-April6
… into bugfix-2.1.x-April6
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
c792921
to
37fb26b
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
37d77d6
to
aa44542
Compare
… into bugfix-2.1.x-April6
… into bugfix-2.1.x-April6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly updating CrealityUI + ProUI spacing. Some tweaking of comments.
GET_TEXT_FandMSG_...from language_en.h instead of literal Strings in CrealityUI, which was aTODO:No other real important code changes, merely just cosmetic or rearranging of code
MSG_UBL_MESH_LEVELING, swap w/`MSG_MESH_LEVELINGMSG_INFO_PRINTER_STATS_MENU, swap w/MSG_INFO_STATS_MENURequirements
Benefits
Less clumped, crowded.
Better readability.
Configurations
Related Issues