Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Various file fixes #27539

Open
wants to merge 9 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Nov 22, 2024

Description

Changes that matter:

  • Add MarlinUI::kill_screen() to Creality UI inorder to remove HAS_UI_UPDATE 1
  • Move #define HAS_STATUS_MESSAGE 1 under where HAS_DISPLAY is defined
  • Move Extra Icons to e3v2/common
  • Update endstops.cpp - add FILAMENT_IS_OUT(), put #include in useful #if statements

Requirements

Benefits

Configurations

Related Issues

@classicrocker883 classicrocker883 changed the title Update HAS_DISPLAY, DWIN_CREALITY_LCD Update Various file fixes Nov 25, 2024
@thinkyhead
Copy link
Member

Where are we in sorting out the DWIN_SET versus TJC situation?

It would be great if you could coordinate with @mriscoc on putting together a comprehensive set of changes. The 2.1.3 beta period will be on for another couple of weeks. If you can gather the most up to date implementation and package it up in a neat PR then I will be very happy to help it get cleaned up and merged ASAP.

@thisiskeithb
Copy link
Member

Where are we in sorting out the DWIN_SET versus TJC situation?

Still a WIP: MarlinFirmware/Configurations#1105 (comment)

@mriscoc
Copy link
Contributor

mriscoc commented Dec 2, 2024

Where are we in sorting out the DWIN_SET versus TJC situation?

It would be great if you could coordinate with @mriscoc on putting together a comprehensive set of changes. The 2.1.3 beta period will be on for another couple of weeks. If you can gather the most up to date implementation and package it up in a neat PR then I will be very happy to help it get cleaned up and merged ASAP.

I stopped using bitmap labels a long time ago. Now I use strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants