Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema.py to work in Windows, update buildroot/bin files #27549

Merged

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Nov 27, 2024

Description

schema.py

  • add encoding='utf-8' to Path.open()
    This allows CONFIG_EXPORT in Configuration_adv.h to work in Windows, otherwise this error appears:
Error: 'charmap' codec can't decode byte 0x90...

buildroot/bin files

  • Removed i variable from build_example because that appears to go unused?? maybe??
  • Removed b variable from mftest because that appears to go unused?? maybe??
  • Arrange as alphabetized

Requirements

Benefits

Configurations

Related Issues

@classicrocker883 classicrocker883 changed the title Fix schema.py to work in Windows Fix **schema.py** to work in Windows, update **buildroot/bin** files Nov 28, 2024
@classicrocker883 classicrocker883 changed the title Fix **schema.py** to work in Windows, update **buildroot/bin** files Fix schema.py to work in Windows, update buildroot/bin files Nov 28, 2024
@thinkyhead thinkyhead merged commit 3591eb5 into MarlinFirmware:bugfix-2.1.x Dec 1, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants