-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add fade out alarm option #2813
base: master
Are you sure you want to change the base?
Conversation
+ Resolves #2106
💖 Thanks for opening this pull request! 💖 |
Features still missing from branch:
Will update the branch once I have added/tested the above features. |
+ Add duration tests
Added seconds, minutes and hours inputs. Thought adding a fade duration wasn't really necessary so didn't include it in the PR. Details in regards to the changes. I changed the I also modified the time and duration settings to be updated on save of the alarm modal. This will prevent the alarm triggering on change of the seconds duration, waiting for the user to press okay to confirm the time allowed. The scenario this would be most handy is if a user set a duration of a second or two. If the settings value was updated on change then the alarm would trigger instantly not allowing the user enough time to click 'ok' to confirm. |
Sorry for the delay on this, I'll take a look this week 👍 |
@jarradizzle do you still want to do this? looks like a nice feature! :) |
@Stanzilla all the changes are here for this feature? I just don't think it has been reviewed yet. Please let me know if anything is missing. |
Dag yo, this feature would be awesome! I'm surprised the PR's been sitting here so long. |
Very new to electron so please let me know if you would like anything changed.
Cheers :)
P.S. Awesome project! Thanks so much for your time and effort in creating this, has really saved my life at work and home.