Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #3745

wants to merge 1 commit into from

Conversation

jnr2820
Copy link

@jnr2820 jnr2820 commented Dec 21, 2019

Added note for Dev build search tool.
https://gpmdp.azurewebsites.net/
Project here: agc93/gpmdp-release

Thanks for taking the time to review this request

  • jnr2820

Added note for Dev build search tool.
https://gpmdp.azurewebsites.net/
Project here: agc93/gpmdp-release
@welcome
Copy link

welcome bot commented Dec 21, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run npm run lint locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
  • If you added new translation strings ensure that you have added empty strings for all languages
  • If you added new functionality or modified existing functionality please ensure it is tested

@MarshallOfSound
Copy link
Owner

Hey @jnr2820 cool tool, looks like @agc93 built this so I'd like sign off from them that they're OK with this going in the README and I'd probably like to CNAME it to the gpmdp domain if they're OK with that 🤔

@agc93
Copy link

agc93 commented Dec 31, 2019

Yep, that was me. The tool itself was always supposed to be a stop-gap to the problem of people having to use CI releases that were difficult to find. Ideally this wouldn't be the long-term solution through which users are installing GPMDP.

I'm totally okay with it going in the README, but given I'm still paying to host the service (currently) I'd prefer to either a) fully hand the tool over and allow you to host it somewhere under the GPMDP domain or b) leave it non-CNAME'd as-is (that is, a temporary solution).

Happy to work with either option, or any other approach you'd prefer 👍


Also to clarify: the tool will now list recent builds, not just the most recent.

@razzeee
Copy link

razzeee commented Mar 17, 2021

I guess the service backend is down by now? So the PR doesn't make sense anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants