Feat: Move logging to ZIO's official logging library #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Hall <[email protected]>
j-hall-mwam
force-pushed
the
zio_logging
branch
from
cebfe96 to
67cc3f8
Compare
Signed-off-by: Jordan Hall <[email protected]>
j-hall-mwam
force-pushed
the
zio_logging
branch
from
7d25b0e to
c130da7
Compare
mmniazi
reviewed
Dec 11, 2023
kafkakewl-deploy/src/main/scala/com/mwam/kafkakewl/deploy/Main.scala
Outdated
Show resolved
Hide resolved
mmniazi
reviewed
Dec 11, 2023
|
|
||
| import java.nio.file.Paths | ||
|
|
||
| object Logging { |
There was a problem hiding this comment.
can you add a comment on PR about exactly what functionality we are losing when going from old logger to new one?
Logging can no longer be Filtered the same way as before. ZIO does not seem to expose a way of modifying a log's level once it has been created.
Seems like you are changing log level in code?
Co-authored-by: Mohsin Niazi <[email protected]> Signed-off-by: Jordan Lloyd Hall <[email protected]>
|
Hello @j-hall-mwam - pls take a look at https://github.com/specmesh/specmesh-build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logging stack is rather deep, this PR aims to reduce it to just the native ZIO logging libraries and remove all other logging dependencies.
Some notes: