Policer counter #3
Open
+364
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiraez
requested review from
amazor,
marvellgit,
matiAlfaro,
VladimirKuk,
aviramd,
DanielaMurin and
shaygol
amazor
approved these changes
Nov 24, 2024
|
|
||
| ``` | ||
| ; Defines information for policer counter | ||
| key = "COUNTERS:counter_oid" ; policer counter statistic |
There was a problem hiding this comment.
There is an extra indent here
| ; Defines information for COUNTERS_POLICER_NAME_MAP | ||
| key = COUNTERS_POLICER_NAME_MAP ; policer name to its oid | ||
| ;field = value | ||
| <policer_name_to_counter> = STRING ; name of the policer, value is the counter OID |
There was a problem hiding this comment.
Maybe just call it <policer_name>? i don't know what "to_counter" means.
| ``` | ||
|
|
||
| PolicerOrch holds a new object of type FlexCounterManager and is initialized with ```StatsMode::READ``` | ||
| and a default polling interval of 10 sec and disable by default: |
There was a problem hiding this comment.
"with a default polling interval of 10 seconds."
I would move "and disabled by default" to after the code block below.
FlexCounterManager m_pc_manager;m_pc_manager is disabled by default.
|
|
||
| ### Warmboot and Fastboot Design Impact | ||
|
|
||
| Counter polling is delayed at system startup. |
There was a problem hiding this comment.
Can you explain a bit more about how it is delayed at startup? Is this a new thing you are adding? Is it because it uses FC?
Either just for me, or if you think it is worth adding to this section as well.
shiraez
force-pushed
the
PolicerCounter
branch
from
97c50eb to
7631525
Compare
shiraez
force-pushed
the
PolicerCounter
branch
from
7631525 to
b1e4882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.