feat(endpoint): add new async receive endpoint #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ledging until the handler has resolved
|
Rebased/merged. |
|
So I rebased and merged all of your outstanding PR's, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the handling of a message will not impact the acknowledgment of the message.
The AsyncReceiveEndpoint waits for the message handler to resolve before acknowledging the message or it noAcks the message when the handler throws.
To not cause breaking changes I've implemented this as a second implementation of the receive endpoint.
I've also incorporated the improvements I've made in #6, so this should probably be merged after #6 so I can remove the unrelated commits from this branch.