Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 [iOS] TipKit 🎉 #113

Merged
merged 2 commits into from
Aug 26, 2024
Merged

🎉 [iOS] TipKit 🎉 #113

merged 2 commits into from
Aug 26, 2024

Conversation

DavidKadlcek
Copy link
Contributor

📝 Description

  • Added support for TipKit. The TipKit is supported from iOS 17. Once you dismiss the Tip, it won't appear anytime, until you reset DataStore. I used default data store. In real project you will not use Tips.resetDatastore(). This is only for testing purposes and demonstration how it works.

💡 What’s new?

  • Added TipKit for iOS

😶 What’s missing?

📚 References

Base automatically changed from fix/ios-build to develop July 26, 2024 07:52
pchmelar
pchmelar previously approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@pchmelar pchmelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ios/PresentationLayer/Recipes/Sources/Recipes/TipKit/ExampleTipKitViewModel.swift Outdated
@Published private(set) var state: State = State()

struct State {
var remainigTapsToShowTip: Int = 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tomas-bat tomas-bat added the enhancement New feature or request label Aug 23, 2024
@DavidKadlcek DavidKadlcek dismissed stale reviews from tomas-bat and pchmelar via f49620c August 26, 2024 09:40
@DavidKadlcek DavidKadlcek merged commit 958b711 into develop Aug 26, 2024
4 checks passed
@DavidKadlcek DavidKadlcek deleted the feature/tip-kit branch August 26, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-bat tomas-bat tomas-bat approved these changes

@pchmelar pchmelar pchmelar left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidKadlcek @pchmelar @tomas-bat