-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Add workaround for using Moko in tests and previews #114
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to test iOS previews and I was getting some error related to our UIToolkit
Bundle+Extensions.swift
file..
It was probably some workaround which now causes crashes, but when I tried to use .module
instead of this workaround, the previews started working 😅 So maybe the workaround is outdated or something..
This isn't really related to this PR, though.. So let me know if you want to look into it and fix it here, or if I should create a task for it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this? 🤔 It seems to be created in the stencil files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried my best to remove the hack from swiftgen files, but this is the best I can do 😅 I think an iOS developer will know more about how they work and will be able to remove a lot of code and then this will not be needed anymore, but that's beyond my skills
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understandable 😅 I checked it and this file can be safely removed. But you don't have to do it here, I think.. We'll do that in MateeStarter.
Don't know why Github decided to close this 😅 |
📝 Description
💡 What’s new?
😶 What’s missing?
📚 References