Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RadioButton and CheckBox custom foreground #3773

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

mzy666888
Copy link
Contributor

add RadioButton and CheckBox custom foreground.

@nicolaihenriksen
Copy link
Contributor

@mzy666888 Just had a quick glance at the changes. I will let @Keboo decide if this should merge or not, but is there a particular reason you have changed the new default brushes such that they don't match what they were before? This seems like a visual breaking change.

@Keboo Keboo added the visual breaking change Items here have affected the visual look of controls. label Jan 24, 2025
@Keboo
Copy link
Member

Keboo commented Jan 24, 2025

Hi @mzy666888, thank you for this PR. Can you elaborate further on the problem you are trying to solve with this. It looks like both of those brushes could have been set inside of your app already.

I am a little hesitant to merge what was two different brushes into a single one.

@Keboo Keboo added the evaluation required Items is pending review or evaluation by the team label Jan 24, 2025
@mzy666888
Copy link
Contributor Author

thank you Keboo, like example, I just want to change the color for checkbox Box foreground and don't want to change the color for content foreground.

if leave it as it is, I will define custom style on my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluation required Items is pending review or evaluation by the team visual breaking change Items here have affected the visual look of controls.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants